user [nfc]: Rename NewGroupPmScreen from CreateGroupScreen

The old name was highly misleading about what this does.

Not to mention the directory it was in -- Zulip user groups are
completely unrelated to group-PM threads, which is what this screen
is actually about.

Author: gnprice

src/nav/AppNavigator.js

@@ -39,7 +39,7 @@ import VariablesScreen from '../diagnostics/VariablesScreen';
 import TimingScreen from '../diagnostics/TimingScreen';
 import StorageScreen from '../diagnostics/StorageScreen';
 import LightboxScreen from '../lightbox/LightboxScreen';
-import CreateGroupScreen from '../user-groups/CreateGroupScreen';
+import NewGroupPmScreen from '../user-picker/NewGroupPmScreen';
 import InviteUsersScreen from '../streams/InviteUsersScreen';
 import StreamSettingsScreen from '../streams/StreamSettingsScreen';
 import CreateStreamScreen from '../streams/CreateStreamScreen';
@@ -73,7 +73,7 @@ export type AppNavigatorParamList = {|
   +users: RouteParamsOf<typeof UsersScreen>,
   +language: RouteParamsOf<typeof LanguageScreen>,
   +lightbox: RouteParamsOf<typeof LightboxScreen>,
-  +'create-group': RouteParamsOf<typeof CreateGroupScreen>,
+  +'new-group-pm': RouteParamsOf<typeof NewGroupPmScreen>,
   +'invite-users': RouteParamsOf<typeof InviteUsersScreen>,
   +diagnostics: RouteParamsOf<typeof DiagnosticsScreen>,
   +variables: RouteParamsOf<typeof VariablesScreen>,
@@ -181,7 +181,7 @@ export default function AppNavigator(props: Props): Node {
       <Stack.Screen name="users" component={useHaveServerDataGate(UsersScreen)} />
       <Stack.Screen name="language" component={useHaveServerDataGate(LanguageScreen)} />
       <Stack.Screen name="lightbox" component={useHaveServerDataGate(LightboxScreen)} />
-      <Stack.Screen name="create-group" component={useHaveServerDataGate(CreateGroupScreen)} />
+      <Stack.Screen name="new-group-pm" component={useHaveServerDataGate(NewGroupPmScreen)} />
       <Stack.Screen name="invite-users" component={useHaveServerDataGate(InviteUsersScreen)} />
       <Stack.Screen name="diagnostics" component={useHaveServerDataGate(DiagnosticsScreen)} />
       <Stack.Screen name="variables" component={useHaveServerDataGate(VariablesScreen)} />

src/pm-conversations/PmConversationsScreen.js

@@ -72,7 +72,7 @@ export default function PmConversationsScreen(props: Props): Node {
           style={styles.button}
           text="New group PM"
           onPress={() => {
-            setTimeout(() => navigation.push('create-group'));
+            setTimeout(() => navigation.push('new-group-pm'));
           }}
         />
       </View>

src/user-groups/CreateGroupScreen.js renamed to src/user-picker/NewGroupPmScreen.js

@@ -10,22 +10,22 @@ import Screen from '../common/Screen';
 import { doNarrow, navigateBack } from '../actions';
 import { pmNarrowFromRecipients } from '../utils/narrow';
 import { pmKeyRecipientsFromUsers } from '../utils/recipient';
-import UserPickerCard from '../user-picker/UserPickerCard';
+import UserPickerCard from './UserPickerCard';
 import { getOwnUserId } from '../users/userSelectors';
 
 type Props = $ReadOnly<{|
-  navigation: AppNavigationProp<'create-group'>,
-  route: RouteProp<'create-group', void>,
+  navigation: AppNavigationProp<'new-group-pm'>,
+  route: RouteProp<'new-group-pm', void>,
 |}>;
 
-export default function CreateGroupScreen(props: Props): Node {
+export default function NewGroupPmScreen(props: Props): Node {
   const { navigation } = props;
   const dispatch = useDispatch();
   const ownUserId = useSelector(getOwnUserId);
 
   const [filter, setFilter] = useState<string>('');
 
-  const handleCreateGroup = useCallback(
+  const handlePickerComplete = useCallback(
     (selected: $ReadOnlyArray<UserOrBot>) => {
       navigation.dispatch(navigateBack());
       dispatch(doNarrow(pmNarrowFromRecipients(pmKeyRecipientsFromUsers(selected, ownUserId))));
@@ -35,7 +35,7 @@ export default function CreateGroupScreen(props: Props): Node {
 
   return (
     <Screen search scrollEnabled={false} searchBarOnChange={setFilter}>
-      <UserPickerCard filter={filter} onComplete={handleCreateGroup} showOwnUser={false} />
+      <UserPickerCard filter={filter} onComplete={handlePickerComplete} showOwnUser={false} />
     </Screen>
   );
 }