Skip to content

Fix Stored XSS in User Profile - first_name Field #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Stored XSS in User Profile - first_name Field #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions SUBMISSION_FIX_XSS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# XSS Fix Implementation Guide

## Issue #357: Stored XSS in User Profile - first_name Field

This document provides the theoretical fix for the XSS vulnerability. The exact file location needs to be identified in the codebase.

## Fix Files Provided

The fix is provided in:
- `SUBMISSION_FILES/FIX_2_XSS/user_serializer.py` - Django serializer with input sanitization
- `SUBMISSION_FILES/FIX_2_XSS/user_view.py` - Django viewset/views with XSS protection

## Implementation

The fix should be applied to the user update endpoint handler that processes `PATCH /api/users/:id/` requests.

### Key Changes:
1. Input sanitization using `bleach.clean()` to strip HTML tags
2. Output encoding using `django.utils.html.escape()` for safe rendering
3. Validation to check for script tags and JavaScript protocols

## Note

Since the exact file location could not be determined through codebase analysis, this fix is provided as a reference implementation. The maintainers should identify the correct file and apply the fix accordingly.