Added ability to override placeholderString #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello @brianjd! Do you feel that setting the |
Author
|
Hey @alvaromb, It wasn't. It is pretty common to have placeholder text that doesn't match the label. In my case I needed placeholder text that was a bit more 'assistful'. |
alvaromb
requested changes
Oct 5, 2016
Collaborator
alvaromb
left a comment
alvaromb
left a comment
There was a problem hiding this comment.
Do you mind to separate the ternary operators in different lines?
It's very hard to read this way. Otherwise, I'm happy accepting the changes and add this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.