Add prefix for Classic Payments

[gcatanese]

Fix namespace conflict between Checkout and Payments

Problem
PaymentsApi and ModificationsApi classes exist in Checkout and `Payments1, creating an error (conflict) during the initialization.

Solution
Introduce a prefix Classic for Payments, to generate the classes as ClassicPaymentsApi and ClassicModificationsApi.

This PR updates the templates and regenerate the code related to Classic Payment. This PR depends on Add Classic prefix when applicable.

Note: renaming Classic services was necessary to avoid changing/affecting Checkout. This will be highlighted in the Release Notes.

---

Fix #324 and #316

[gemini-code-assist]

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical namespace collision that occurred between the 'Checkout' and 'Payments' API services. The solution involves strategically renaming the conflicting 'PaymentsApi' and 'ModificationsApi' classes within the 'Payments' service by prepending them with a 'Classic' prefix. This ensures proper class resolution and prevents initialization errors, thereby maintaining the integrity and distinctness of both API integrations. The changes include updating core service files and the underlying code generation templates to consistently apply this new naming convention, alongside a new test case to highlight the previously existing issue.

Highlights

• Namespace Conflict Resolution: Addressed a critical namespace conflict between the 'Checkout' and 'Payments' services by introducing a 'Classic' prefix for the 'PaymentsApi' and 'ModificationsApi' classes within the 'Payments' service.
• Class Renaming: Renamed 'Adyen::ModificationsApi' to 'Adyen::ClassicModificationsApi' and 'Adyen::PaymentsApi' to 'Adyen::ClassicPaymentsApi' in the 'payment' service to resolve the naming collision.
• Code Generation Template Updates: Modified the code generation templates ('api-single.mustache' and 'api.mustache') to automatically apply the 'Classic' prefix to relevant Payment service classes during generation.
• New Test Case for Collision Detection: Added a new test in 'spec/checkout_spec.rb' to explicitly detect and document the previous namespace collision, which is expected to fail once the fix is fully implemented, confirming the resolution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a namespace conflict between Checkout and Payments services by prefixing the Payments API classes with Classic. The changes in the service files and templates correctly implement this solution. My main feedback is on the new test case added in spec/checkout_spec.rb, which contains debugging statements and has flawed logic. I've suggested a replacement for the test to correctly verify the fix.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pplant]

Nice!