Skip to content

Highlighting if empty targets are provided #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 27, 2025
Merged

Highlighting if empty targets are provided #102

merged 12 commits into from
Feb 27, 2025

Conversation

@goergisn
Copy link
Contributor

@goergisn goergisn commented Feb 27, 2025 •
edited
Loading

Summary

  • Highlights if no analyzable targets could be found / were passed to the OutputGenerator

Changes

  • If the OutputGenerator gets called with an empty (but non-nil) list of targets it now shows a different title, highlighting some misconfiguration.
Screenshot 2025-02-27 at 13 42 29

atmamont
atmamont approved these changes Feb 27, 2025
View reviewed changes
Tests/UnitTests/OutputGeneratorTests.swift Outdated
class OutputGeneratorTests {

func test_noChanges_singleModule() {
@Test
Copy link

@atmamont atmamont Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 27, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link

github-actions bot commented Feb 27, 2025

✅ No changes detected

Comparing notify-on-empty-targets to main

Analyzed targets: FileHandlingModule, PADCore, PADLogging, PADOutputGenerator, PADPackageFileAnalyzer, PADProjectBuilder, PADSwiftInterfaceDiff, PADSwiftInterfaceFileLocator, ShellModule, SwiftPackageFileHelperModule

@goergisn goergisn merged commit e04b085 into main Feb 27, 2025
6 checks passed
@goergisn goergisn deleted the notify-on-empty-targets branch February 27, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atmamont atmamont atmamont approved these changes

@erenbesel erenbesel Awaiting requested review from erenbesel

@nauaros nauaros Awaiting requested review from nauaros

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goergisn @atmamont