-
-
Notifications
You must be signed in to change notification settings - Fork 225
fix(cli): turbo prune --docker misses tsconfig.base.json used by gene… #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AmanVarshney01
merged 24 commits into
AmanVarshney01:main
from
moreorover:fix/config-package
Nov 10, 2025
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
9ca2b97
fix(cli): turbo prune --docker misses tsconfig.base.json used by gene…
moreorover 3363245
feat: tests
moreorover e14b2c6
feat: tests
moreorover f6d9d41
feat: tests
moreorover 3a0b89b
feat: tests
moreorover 629fab7
feat: tests
moreorover f591de5
feat: tests
moreorover 66b5aa8
feat: tests
moreorover e753bc9
feat: rollback devDependencies
moreorover 9edd4d7
feat: ai
moreorover 35c3b56
Revert "feat: ai"
moreorover 84ce7d2
feat: config
moreorover 0eac7fe
feat: config
moreorover ca0f02e
feat: rabbit
moreorover 90b332a
feat: rabbit
moreorover 6e3ad46
feat: prune tests
moreorover 751eb2e
feat: prune tests
moreorover d7ac29a
feat: wrangler tests
moreorover 3894a97
Merge branch 'main' into fix/config-package
moreorover fcff4a0
feat: tests
moreorover 8990bcd
Merge remote-tracking branch 'origin/fix/config-package' into fix/con…
moreorover 4afc09f
Merge branch 'main' into fix/config-package
AmanVarshney01 1de76ce
Merge branch 'main' into fix/config-package
moreorover e3c355e
fix
AmanVarshney01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
apps/cli/templates/auth/better-auth/server/base/tsconfig.json.hbs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "name": "@{{projectName}}/config", | ||
| "version": "0.0.0", | ||
| "private": true | ||
| } |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,229 @@ | ||
| import { afterAll, beforeAll, describe, it } from "vitest"; | ||
| import { | ||
| cleanupSmokeDirectory, | ||
| runTRPCTest, | ||
| validateConfigPackageSetup, | ||
| validateTurboPrune, | ||
| } from "./test-utils"; | ||
|
|
||
| describe("Config Package Feature", () => { | ||
| beforeAll(async () => { | ||
| await cleanupSmokeDirectory(); | ||
| }); | ||
| afterAll(async () => { | ||
| await cleanupSmokeDirectory(); | ||
| }); | ||
|
|
||
| describe("Basic Stack Configurations", () => { | ||
| it("should validate hono + pnpm + turbo stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "hono-pnpm", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| packageManager: "pnpm", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| api: "trpc", | ||
| frontend: ["tanstack-router"], | ||
| addons: ["turborepo"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| await validateTurboPrune(result); | ||
| }); | ||
|
|
||
| it("should validate hono + pnpm + turbo + wrangler stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "hono-pnpm-turbo-wrangler", | ||
| backend: "hono", | ||
| runtime: "workers", | ||
| packageManager: "pnpm", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| api: "trpc", | ||
| frontend: ["tanstack-router"], | ||
| addons: ["turborepo"], | ||
| serverDeploy: "wrangler", | ||
| webDeploy: "wrangler", | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| await validateTurboPrune(result); | ||
| }); | ||
|
|
||
| it("should validate hono + node stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "hono-node", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| api: "trpc", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate hono + bun stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "hono-bun", | ||
| backend: "hono", | ||
| runtime: "bun", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| api: "trpc", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate express + node stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "express-node", | ||
| backend: "express", | ||
| runtime: "node", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate fastify + node stack", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "fastify-node", | ||
| backend: "fastify", | ||
| runtime: "node", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
| }); | ||
|
|
||
| describe("Full Stack with Authentication", () => { | ||
| it("should validate full stack with better-auth", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "full-stack-auth", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| database: "postgres", | ||
| orm: "drizzle", | ||
| api: "trpc", | ||
| auth: "better-auth", | ||
| frontend: ["tanstack-router"], | ||
| addons: ["turborepo"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| await validateTurboPrune(result); | ||
| }); | ||
| }); | ||
|
|
||
| describe("API Variants", () => { | ||
| it("should validate stack with tRPC", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "trpc-api", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| api: "trpc", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate stack with oRPC", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "orpc-api", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| api: "orpc", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
| }); | ||
|
|
||
| describe("Edge Cases", () => { | ||
| it("should validate frontend-only stack (no backend)", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "frontend-only", | ||
| backend: "none", | ||
| runtime: "none", | ||
| database: "none", | ||
| orm: "none", | ||
| api: "none", | ||
| auth: "none", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate convex backend", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "convex-backend", | ||
| backend: "convex", | ||
| runtime: "none", | ||
| database: "none", | ||
| orm: "none", | ||
| api: "none", | ||
| frontend: ["next"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate self-hosted backend", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "self-backend", | ||
| backend: "self", | ||
| runtime: "none", | ||
| api: "trpc", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| frontend: ["next"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate stack without database", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "no-database", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| database: "none", | ||
| orm: "none", | ||
| api: "trpc", | ||
| frontend: ["tanstack-router"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| }); | ||
|
|
||
| it("should validate stack with turborepo addon", async () => { | ||
| const result = await runTRPCTest({ | ||
| projectName: "with-turborepo", | ||
| backend: "hono", | ||
| runtime: "node", | ||
| database: "sqlite", | ||
| orm: "drizzle", | ||
| frontend: ["tanstack-router"], | ||
| addons: ["turborepo"], | ||
| install: false, | ||
| }); | ||
| await validateConfigPackageSetup(result); | ||
| await validateTurboPrune(result); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Root Package Missing Dev Dependency
The root
package.jsondoesn't get the config package added as a dev dependency. TheaddPackageDependencycall forprojectDiris missingcustomDevDependencies: configDep, but the test validation at line 253-255 expects@{projectName}/configto be in the root'sdevDependencies. All other packages correctly receive this dependency.