Skip to content

Use Muxer from .NET SDK for dotnet discovery #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 18, 2025
Merged

Use Muxer from .NET SDK for dotnet discovery #4732

merged 8 commits into from
Nov 18, 2025

Conversation

@liliankasem
Copy link
Member

@liliankasem liliankasem commented Nov 17, 2025

Issue describing the changes in this PR

resolves #4725, #3285

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Replace CommandChecker.CommandExists with DotnetMuxer class copied from the .NET SDK to improve dotnet installation discovery. This provides more comprehensive detection using multiple fallback strategies including DOTNET_HOST_PATH, DOTNET_ROOT, and process path resolution.

Changes:

  • Add DotnetMuxer and FileNameSuffixes helper classes from dotnet/sdk
  • Update EnsureDotnet() to use DotnetMuxer.MuxerPath with better error handling
  • Remove multi-TFM conditionals since CLI only targets net8.0
  • Improve error message to include all discoverable environment variables

@liliankasem liliankasem requested a review from a team as a code owner November 17, 2025 19:13
jviau
jviau reviewed Nov 17, 2025
View reviewed changes
jviau
jviau reviewed Nov 17, 2025
View reviewed changes
@liliankasem liliankasem force-pushed the liliankasem/use-dotnet-muxer-from-dotnetcli branch from 94bfefc to 48de81b Compare November 17, 2025 22:13
aishwaryabh
aishwaryabh approved these changes Nov 17, 2025
View reviewed changes
Copy link
Contributor

@aishwaryabh aishwaryabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

jaliyaudagedara
jaliyaudagedara reviewed Nov 18, 2025
View reviewed changes
@liliankasem liliankasem merged commit 59b8110 into main Nov 18, 2025
38 checks passed
@liliankasem liliankasem deleted the liliankasem/use-dotnet-muxer-from-dotnetcli branch November 18, 2025 18:32
This was referenced Nov 19, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jviau jviau jviau approved these changes

@aishwaryabh aishwaryabh aishwaryabh approved these changes

+1 more reviewer

@jaliyaudagedara jaliyaudagedara jaliyaudagedara left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Azure DevOps: Azure Functions Core Tools Can't Find .NET 10 Installed by UseDotNet@2 Task on Windows Agents

5 participants

@liliankasem @jviau @jaliyaudagedara @aishwaryabh