Skip to content

Conversation

@mpodwysocki
Copy link
Contributor

Things to consider before you submit the PR:

  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

This adds Browser Push support with the following additions:

  • Created per PNS notification classes instead of the Notification class itself
    • AdmNotification
    • AppleNotification
    • BaiduNotification
    • BrowserNotification
    • FcmNotification
    • MpnsNotification
    • WindowsNotification
  • Added Browser Credentials and updated the RegistrationDescription
  • Added BrowserRegistration and BrowserTemplateRegistration classes to support registrations
  • Added BrowserInstallation to differ from regular Installations which have a string device ID versus the BrowserPushChannel
  • Added method to save an installation through the BaseInstallation
  • Added methods for getting both a regular Installation and BrowserInstallation on the NotificationHubClient

Misc stuff fixed:

  • Added JavaDoc to all public members
  • Rewrote equals and hashcode implementations based upon IntelliJ recommendations
  • Migrated SAS token creation to a single SasTokenProvider

Related PRs or issues

N/A

Misc

N/A

Copy link
Member

@marstr marstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit of meta feedback - this is a pretty noisy PR to review. :) It would've been nice to have some of the more ticky-tacky changes like adding comments, changing parameter names, etc in a separate commit or two so I could focus on semantic changes in a vacuum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants