Skip to content

feat (lazysizes): improves initial page load performance #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −3
Open

feat (lazysizes): improves initial page load performance #468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/conf-img/tpl/default-picture-nolazyload-caption.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<picture>
%%data-location%%
%%sources%%
<img %%src%% fetchpriority="high" %%attributes%%>
<img %%src%% fetchpriority="high" decoding="async" %%attributes%%>
Copy link

@sourcery-ai sourcery-ai bot Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (performance): Reconsider using decoding="async" on images marked with fetchpriority="high".

On critical, above-the-fold images, decoding="async" can delay when the image is decoded and painted, undermining the benefit of fetchpriority="high". Consider either omitting decoding so the browser can choose, or using decoding="sync" (or making this configurable) for non-lazyloaded LCP candidates to avoid potential regressions in perceived load performance.

</picture>
<figcaption>%%caption%%</figcaption>
<figcaption>%%caption%%</figcaption>
2 changes: 1 addition & 1 deletion assets/conf-img/tpl/default-picture-nolazyload.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<picture>
%%data-location%%
%%sources%%
<img %%src%% fetchpriority="high" %%attributes%%>
<img %%src%% fetchpriority="high" decoding="async" %%attributes%%>
</picture>
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"license": "GPL-2.0",
"dependencies": {
"@fontsource/poppins": "^5.0.5",
"lazysizes": "^5.3.2",
"oneloop.js": "^5.2.1"
},
"devDependencies": {
Expand Down
1 change: 1 addition & 0 deletions src/js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'lazysizes'
import './classes/ScrollDirection'
import './classes/ButtonSeoClick'
import './classes/Header'
Expand Down
8 changes: 8 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2272,6 +2272,7 @@ __metadata:
imagemin-jpegtran: "npm:^7.0.0"
imagemin-optipng: "npm:^8.0.0"
imagemin-svgo: "npm:^10.0.1"
lazysizes: "npm:^5.3.2"
mini-css-extract-plugin: "npm:^1.5.0"
oneloop.js: "npm:^5.2.1"
postcss: "npm:^8.4.24"
Expand Down Expand Up @@ -6703,6 +6704,13 @@ __metadata:
languageName: node
linkType: hard

"lazysizes@npm:^5.3.2":
version: 5.3.2
resolution: "lazysizes@npm:5.3.2"
checksum: 10/15dfa1cc8bf8c3a4393014d411f161cb1df96ab0888a0776ba4dc34d45c6ba9c5d2b2eca22683c14dfeee552c67173cb9a512d640d3424d9910c0246e15c4edc
languageName: node
linkType: hard

"levn@npm:^0.4.1":
version: 0.4.1
resolution: "levn@npm:0.4.1"
Expand Down
Loading