Merge branch 'ChromeDevTools:main' into main

Author: tysonthomas9

AUTHORS

@@ -33,6 +33,7 @@ Danny Eldridge <me@heardanieljames.com>
 Derek Li <the.derekli@gmail.com>
 Douglas Chiang <douglasdothnc@gmail.com>
 Dragonish <no.web.developer@outlook.com>
+Eden Wang <nedenwang@gmail.com>
 Edward Trist <edwardtrist@gmail.com>
 Ergün Erdoğmuş <erdogmusergun@gmail.com>
 Eric Rannaud <eric.rannaud@gmail.com>

DEPS

@@ -12,27 +12,27 @@ vars = {
   'build_with_chromium': False,
 
   'build_url': 'https://chromium.googlesource.com/chromium/src/build.git',
-  'build_revision': 'dd54bc718b7c5363155660d12b7965ea9f87ada9',
+  'build_revision': 'd496fc3c8221c758ac43bb6f4ee1b241533efec8',
 
   'buildtools_url': 'https://chromium.googlesource.com/chromium/src/buildtools.git',
-  'buildtools_revision': '88a3274e7b0c6314c84ed202ee6377d1cf9e22b0',
+  'buildtools_revision': '00586fa43b1dedbd119cfd5c71cb9396d09d53e0',
 
   'depot_tools_url': 'https://chromium.googlesource.com/chromium/tools/depot_tools.git',
-  'depot_tools_revision': '73e46667ed3a1326cf564747737b4e11137d7f29',
+  'depot_tools_revision': 'a5514728766942dd77a2c0d222fb6c9d5a9d9b9d',
 
   'inspector_protocol_url': 'https://chromium.googlesource.com/deps/inspector_protocol',
-  'inspector_protocol_revision': '1ac1ec6d0c61c081cc73793e491b987beecccde1',
+  'inspector_protocol_revision': '679b33a98ae546ff521eee2ea28d8d5bf28872ba',
 
   # Keeping track of the last time we rolled the browser protocol files.
-  'chromium_browser_protocol_revision' : 'c0cd408650a942d836b07c15facd3f4fede1d578',
+  'chromium_browser_protocol_revision' : '4ceac4e2889e841baa72d3beb6c8eac6c0d2341e',
 
   'clang_format_url': 'https://chromium.googlesource.com/external/github.com/llvm/llvm-project/clang/tools/clang-format.git',
-  'clang_format_revision': '37f6e68a107df43b7d7e044fd36a13cbae3413f2',
+  'clang_format_revision': 'c2725e0622e1a86d55f14514f2177a39efea4a0e',
 
   'emscripten_tag': 'ade9d780ff17c88d81aa13860361743e3c1e1396',
 
   # GN CIPD package version.
-  'gn_version': 'git_revision:81b24e01531ecf0eff12ec9359a555ec3944ec4e',
+  'gn_version': 'git_revision:5ddf42d01f30d9db392aedf2cf7e0f36980c882d',
 
   'cmake_version': 'version:2@3.21.3',
 
@@ -49,7 +49,7 @@ vars = {
   # Chrome version used for tests. It should be regularly updated to
   # match the Canary version listed here:
   # https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json
-  'chrome': '142.0.7439.0',
+  'chrome': '143.0.7459.0',
 
   # 'magic' text to tell depot_tools that git submodules should be accepted but
   # but parity with DEPS file is expected.
@@ -59,7 +59,7 @@ vars = {
   'non_git_source': 'True',
 
   # siso CIPD package version
-  'siso_version': 'git_revision:acfc39d4c923834851300e8676daf8fc47e53a2d',
+  'siso_version': 'git_revision:2eee1d6feaab76d99397d4d840bd369a428c01ea',
 }
 
 # Only these hosts are allowed for dependencies in this DEPS file.

build

@@ -69,7 +69,6 @@ grd_files_bundled_sources = [
   "front_end/Images/brush.svg",
   "front_end/Images/bucket.svg",
   "front_end/Images/bug.svg",
-  "front_end/Images/bundle.svg",
   "front_end/Images/button-magic.svg",
   "front_end/Images/calendar-today.svg",
   "front_end/Images/center-focus-weak.svg",
@@ -564,8 +563,10 @@ grd_files_bundled_sources = [
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorInsufficientResources.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorInvalidMatchField.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorInvalidStructuredHeader.md",
+  "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorInvalidTTLField.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNavigationRequest.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNoMatchField.md",
+  "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNonIntegerTTLField.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNonListMatchDestField.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNonSecureContext.md",
   "front_end/models/issues_manager/descriptions/sharedDictionaryWriteErrorNonStringIdField.md",
@@ -1120,6 +1121,7 @@ grd_files_unbundled_sources = [
   "front_end/core/sdk/ResourceTreeModel.js",
   "front_end/core/sdk/RuntimeModel.js",
   "front_end/core/sdk/SDKModel.js",
+  "front_end/core/sdk/ScopeTreeCache.js",
   "front_end/core/sdk/ScreenCaptureModel.js",
   "front_end/core/sdk/Script.js",
   "front_end/core/sdk/SecurityOriginManager.js",
@@ -1314,7 +1316,6 @@ grd_files_unbundled_sources = [
   "front_end/models/project_settings/ProjectSettingsModel.js",
   "front_end/models/source_map_scopes/NamesResolver.js",
   "front_end/models/source_map_scopes/ScopeChainModel.js",
-  "front_end/models/source_map_scopes/ScopeTreeCache.js",
   "front_end/models/stack_trace/StackTrace.js",
   "front_end/models/stack_trace/StackTraceImpl.js",
   "front_end/models/stack_trace/StackTraceModel.js",
@@ -1526,18 +1527,20 @@ grd_files_unbundled_sources = [
   "front_end/panels/application/components/backForwardCacheView.css.js",
   "front_end/panels/application/components/badge.css.js",
   "front_end/panels/application/components/bounceTrackingMitigationsView.css.js",
+  "front_end/panels/application/components/endpointsGrid.css.js",
   "front_end/panels/application/components/frameDetailsReportView.css.js",
   "front_end/panels/application/components/interestGroupAccessGrid.css.js",
   "front_end/panels/application/components/originTrialTokenRows.css.js",
   "front_end/panels/application/components/originTrialTreeView.css.js",
   "front_end/panels/application/components/permissionsPolicySection.css.js",
   "front_end/panels/application/components/protocolHandlersView.css.js",
-  "front_end/panels/application/components/reportingApiGrid.css.js",
+  "front_end/panels/application/components/reportsGrid.css.js",
   "front_end/panels/application/components/serviceWorkerRouterView.css.js",
   "front_end/panels/application/components/sharedStorageAccessGrid.css.js",
   "front_end/panels/application/components/sharedStorageMetadataView.css.js",
   "front_end/panels/application/components/stackTraceLinkButton.css.js",
   "front_end/panels/application/components/stackTraceRow.css.js",
+  "front_end/panels/application/components/storageMetadataView.css.js",
   "front_end/panels/application/components/trustTokensView.css.js",
   "front_end/panels/application/cookieItemsView.css.js",
   "front_end/panels/application/indexedDBViews.css.js",
@@ -1872,8 +1875,6 @@ grd_files_unbundled_sources = [
   "front_end/panels/network/components/RequestTrustTokensView.js",
   "front_end/panels/network/components/ResponseHeaderSection.css.js",
   "front_end/panels/network/components/ResponseHeaderSection.js",
-  "front_end/panels/network/components/WebBundleInfoView.css.js",
-  "front_end/panels/network/components/WebBundleInfoView.js",
   "front_end/panels/network/eventSourceMessagesView.css.js",
   "front_end/panels/network/forward/NetworkRequestId.js",
   "front_end/panels/network/forward/UIFilter.js",
@@ -2560,6 +2561,7 @@ grd_files_unbundled_sources = [
   "front_end/ui/components/helpers/directives.js",
   "front_end/ui/components/helpers/get-root-node.js",
   "front_end/ui/components/helpers/scheduled-render.js",
+  "front_end/ui/components/highlighting/HighlightElement.js",
   "front_end/ui/components/highlighting/HighlightManager.js",
   "front_end/ui/components/icon_button/FileSourceIcon.js",
   "front_end/ui/components/icon_button/Icon.js",
@@ -2696,7 +2698,6 @@ grd_files_unbundled_sources = [
   "front_end/ui/legacy/Widget.js",
   "front_end/ui/legacy/XElement.js",
   "front_end/ui/legacy/XLink.js",
-  "front_end/ui/legacy/XWidget.js",
   "front_end/ui/legacy/ZoomManager.js",
   "front_end/ui/legacy/checkboxTextLabel.css.js",
   "front_end/ui/legacy/components/color_picker/ColorFormatSpec.js",

buildtools

@@ -77,7 +77,6 @@ devtools_svg_sources = [
   "brush.svg",
   "bucket.svg",
   "bug.svg",
-  "bundle.svg",
   "button-magic.svg",
   "calendar-today.svg",
   "center-focus-weak.svg",

config/gni/devtools_grd_files.gni

@@ -60,6 +60,7 @@ below.**
 
 ### Policies
 
+*   [Chromium DevTools Console Policy](./policy/console-policy.md)
 *   [Chromium DevTools Slow-Close Policy](./policy/slow-close.md)
 *   [DevTools Page Zoom Accessibility Policy](./policy/gar-page-zoom-policy.md)
 

config/gni/devtools_image_files.gni

@@ -3,5 +3,6 @@
 This folder contains the policies relevant to the development of the Chromium
 DevTools.
 
+1. [Chromium DevTools Console Policy](./console-policy.md)
 1. [Chromium DevTools Slow-Close Policy](./slow-close.md)
 2. [DevTools Page Zoom Accessibility Policy](./gar-page-zoom-policy.md)

docs/README.md

@@ -0,0 +1,144 @@
+# Chromium DevTools Console Policy
+
+[goo.gle/devtools-console-policy](http://goo.gle/devtools-console-policy)
+([go/chrome-devtools:console-policy](http://go/chrome-devtools:console-policy))
+
+**TL;DR:** This policy outlines a strategy to keep the signal to noise ratio in
+the Console panel of Chromium DevTools high, by setting clear expectations for
+Chromium teams what kind of information is presented to web developers via the
+Console and how it is presented. Console spam, specifically from Chromium
+itself, is a known pain point for developers (e.g.
+[crbug/338403584](http://crbug.com/338403584)).
+
+## Background
+
+The [Console panel](https://developer.chrome.com/docs/devtools/console) in the
+Chromium Developer Tools is usually the first place where web developers check
+in case something is not working as expected, and ideally they would come across
+an error or warning message here that helps them to quickly resolve the issue at
+hand. The panel shows all the messages that are logged by the web application
+but also the browser (potentially on behalf of the web application, for example
+logging uncaught exceptions).
+
+In order for it to remain useful to web developers, the signal to noise ratio
+must be as high as possible, and it’s crucially important to keep in mind that
+the information shown is (a) relevant to what the developer is looking for right
+now and (b) actionable wrt. to the issue at hand. Putting it the other way
+around, while the developer is focused on investigating a concrete problem it
+doesn’t help to show a lot of messages around potential issues, suggested
+improvements, or things that went wrong without any useful breadcrumbs (prime
+examples here are error messages from somewhere deep in Blink which contain no
+stack traces and basically just repeat the information that is already present
+on a JavaScript exception throw at the same time).
+
+## Common problems
+
+### Useless anchor
+
+A common problem we’ve observed is console messages from Chromium without a
+meaningful and actionable stack trace. Consider the following example, where the
+location attached to the console message is the first line of the main document.
+The inexperienced web developer will probably be puzzled how come
+`<!doctype html>` activates fingerprinting protection on the current page.
+
+![](./images/console-policy1.png "Useless message anchors")
+
+### For your information
+
+From a Chromium team working on a specific feature, it might be totally
+reasonable to _”let the developer know what’s going on”_, because something
+could break. But from a user’s perspective, messages that basically only convey
+non-actionable information and aren’t relevant in the context of the problem
+that the developer is investigating are useless at best. Consider the following
+example:
+
+![](./images/console-policy2.png "Confusing FYI messages")
+
+The first warning message says that Fingerprinting protection is active, but
+doesn’t tell the developer whether that’s a problem or not, and what they can do
+about it. It’s highly confusing. The second warning message states that two
+third-party cookies were blocked, but also leaves the developer wondering if
+that’s something to be concerned about or caused any actual problem.
+
+Similar messages that fall into this bucket:
+
+* `Third-party cookie will be blocked. Learn more in the Issues tab`
+* `[Violation] 'setTimeout' handler took <N>ms`
+* `[Violation] Added non-passive event listener to a scroll-blocking <some> event. Consider marking event handler as 'passive' to make the page more responsive. See <URL>`
+* `Specifying 'overflow: visible' on img, video and canvas tags may cause them to produce visual content outside of the element bounds. See https://github.com/WICG/view-transitions/blob/main/debugging_overflow_on_images.md for details.`
+
+Logging a message to the Console panel just to tell the developer to open
+another panel or read some article is specifically annoying, and over time will
+result in training web developers on ignoring messages produced by Chromium
+itself.
+
+### Repetition
+
+Repeating the same message over and over again (independent of whether it’s
+actionable and meaningful) is another source of problems:
+
+![](./images/console-policy3.png "Repeated console messages")
+
+DevTools has a feature to group similar messages, which most users have enabled,
+so the pain they feel from a lot of repeated information is manageable. But that
+also gives rise to a new problem: Problems might be hidden through the grouping
+feature outside of the viewport, because the grouping somewhat breaks the
+chronological order.
+
+## Best practice
+
+Specifically for the purpose of being able to present developers with actionable
+information, coupled with traces of data that are relevant to the issue, we’ve
+introduced the [Issues panel], and as part of
+[crbug/40173406](http://crbug.com/40173406) and related bugs already migrated a
+few spammy console messages to issues.
+
+In general, reserve the use of `context->AddConsoleMessage(...)` and similar
+APIs for rare cases when the console message adds significant value, favor a
+well-worded and helpful issue over a console message, and specifically don’t
+spit out a console message when you are already raising an exception (exceptions
+can be coupled with issues internally to provide more actionable information).
+
+## Building empathy
+
+Many Chromies might not be able to immediately relate to the struggles of web
+developers, and might not have first hand experience with sifting through
+endless logs of useless information produced by frameworks, libraries, and
+eventually the browser. But imagine the following scenario: You are using `gdb`
+or `lldb` and instead of helping you diagnose the crash somewhere deep in your
+C++ code for Autofill in the browser process, it’s spamming you with pages of
+potential performance improvements in the renderer code for `<canvas>` elements.
+At best that would be very confusing, but more likely you’d be very frustrated
+with the tool after a while. This is exactly what happens if we spam web
+developers with potential performance issues.
+
+We have a [logging policy for Chromium] to prevent ourselves from being
+overwhelmed by log messages from other Chromium teams, for the same reason.
+
+## GTM strategy
+
+The most common cause for spammy console messages from Chromium is an
+insufficient Go-To-Market (GTM) strategy for features or (potentially breaking)
+changes when it comes to developer adoption. Oftentimes it’s unclear what
+exactly the expectations are and what are the critical user journeys that web
+developers go through. Spending a bit more time on this aspect and involving
+DevRel early on can help to shine light on the matter and avoid sprinkling log
+messages all over the place to _”raise awareness”_. Specifically consider:
+
+- The precise target audience for your information, because not all web
+  developers are equal at all times.
+- Under which exact circumstances that piece of information is required.
+- Is it a nice to have (e.g. _”X could be faster if you did Y”_ or _”using A
+  poses a potential security risk for your users”_) or a critically important
+  piece of information (e.g. _”X will stop working in the next release unless
+  you do Y”_).
+
+Feel free to reach out to [devtools-dev@chromium.org] with questions, and ping
+[dsv@chromium.org](mailto:dsv@chromium.org) (Chrome DevTools TL) or
+[hablich@chromium.org](mailto:hablich@chromium.org) (Chrome DevTools PM)
+directly (specifically in case of code reviews which add new problematic console
+messages).
+
+  [Issues panel]: https://developer.chrome.com/docs/devtools/issues
+  [logging policy for Chromium]: https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++.md#logging
+  [devtools-dev@chromium.org]: https://groups.google.com/a/chromium.org/g/devtools-dev