Fix setting CesiumGeoreference.ellipsoid #637
Open
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting CesiumGeoreference.ellipsoid currently does not work as intended at runtime.
In the editor, CesiumGeoreference.ellipsoidOverride is set, with a call to CesiumGeoreference.ReloadEllipsoid() to ensure the cached _ellipsoid is set up and all transforms updated. However, ellipsoidOverride is private and is not accessible at runtime.
This PR changes the setter for ellipsoid to instead set the _ellipsoidOverride and call ReloadEllipsoid(), providing the functionality that was previously only available from the editor.
Issue number or link
#636
Author checklist
CHANGES.mdwith a short summary of my change (for user-facing changes).Remaining Tasks
Testing plan
Tested the changes in the context of a Unity project. Changing Georeference.ellipsoid previously had effectively no effect. After the change the Georeference calculations properly used the new ellipsoid.