[EAGLE-7007]: Prevent TypeError during model version creation #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading a model, the `get_model_version_proto` function in `clarifai/runners/models/model_builder.py` gathers method signatures to include in the model version protobuf. For older, "proto-style" methods, the signature is intentionally set to `None`. This `None` value was being passed to the `resources_pb2.ModelVersion` constructor, which expects a `MethodSignature` object, resulting in a `TypeError`. This change filters out any `None` values from the list of signatures before they are used, ensuring that only valid `MethodSignature` objects are passed to the protobuf constructor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a model, the
get_model_version_protofunction inclarifai/runners/models/model_builder.pygathers method signatures to include in the model version protobuf.For older, "proto-style" methods, the signature is intentionally set to
None. ThisNonevalue was being passed to theresources_pb2.ModelVersionconstructor, which expects aMethodSignatureobject, resulting in aTypeError.This change filters out any
Nonevalues from the list of signatures before they are used, ensuring that only validMethodSignatureobjects are passed to the protobuf constructor.