Skip to content

Fix eager loading of hierarchies by defining the primary key #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+4 −0
Merged

Fix eager loading of hierarchies by defining the primary key #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/closure_tree/support.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ def hierarchy_class_for_model
# Rails 8.1+ requires an implicit_order_column for models without a primary key
self.implicit_order_column = 'ancestor_id'

# Rails uses the primary key to correctly match associations when using a join to preload (e.g. via `eager_load`).
# The migration generator adds a unique index across these three columns so this is safe.
self.primary_key = [:ancestor_id, :descendant_id, :generations]

belongs_to :ancestor, class_name: model_class_name
belongs_to :descendant, class_name: model_class_name
def ==(other)
Expand Down
Loading