[Port dspace-9_x] Fix #4241 language selection #4907
+120
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 6, 2025 16:46
Consider the language set in the users profile when setting it on page load. Also match languages case-insensitive. Updated tests
…41-language-selection-contribute-9_x
tdonohue
added
bug
i18n / l10n
tdonohue
requested changes
Dec 5, 2025
Member
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
@AbhinavS96 : Thanks for this backport! However, I think there's a line missing from this backport that exists in #4805 (and all other backports). Could you take a look at my inline comment below and get this PR updated? Thanks!
| * @returns {Observable<string[]>} | ||
| */ | ||
| getLanguageCodeList(): Observable<string[]> { | ||
| getLanguageCodeList(ignoreEPersonSettings = false): Observable<string[]> { |
Member
There was a problem hiding this comment.
@AbhinavS96 : It appears this new setting isn't being used in this backport. Shouldn't this be used below on line 66 just like in #4805?
github-project-automation
bot
moved this to 👀 Under Review
in DSpace Maintenance (9.x, 8.x, 7.6.x)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #4805