Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 1, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 5.1.0 -> 5.2.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-51999

Withdrawn Advisory

This advisory has been withdrawn because it describes a correctness bug, not a vulnerability with real security impact. This link is maintained to preserve external references.

Original Description

Impact

when using the extended query parser in express ('query parser': 'extended'), the request.query object inherits all object prototype properties, but these properties can be overwritten by query string parameter keys that match the property names

Important

the extended query parser is the default in express 4; this was changed in express 5 which by default uses the simple query parser

Patches

the issue has been patched to ensure request.query is a plain object so request.query no longer has object prototype properties. this brings the default behavior of extended query parsing in line with express's default simple query parser

Workaround

this only impacts users using extended query parsing ('query parser': 'extended'), which is the default in express 4, but not express 5. all users are encouraged to upgrade to the patched versions, but can otherwise work around this issue:

provide qs directly and specify plainObjects: true

app.set('query parser',
  function (str) {
    return qs.parse(str, {
      plainObjects: true
  });
});

Release Notes

expressjs/express (express)

v5.2.0

Compare Source

========================

  • Security fix for CVE-2024-51999 (GHSA-pj86-cfqh-vqx6)
  • deps: body-parser@^2.2.1
  • A deprecation warning was added when using res.redirect with undefined arguments, Express now emits a warning to help detect calls that pass undefined as the status or URL and make them easier to fix.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Dec 1, 2025
@renovate renovate bot requested a review from a team as a code owner December 1, 2025 22:00
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Dec 1, 2025

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 164.11 KiB 164.11 KiB 0 B 0.00%
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00%
Rum Recorder 19.62 KiB 19.62 KiB 0 B 0.00%
Logs 55.91 KiB 55.91 KiB 0 B 0.00%
Flagging 944 B 944 B 0 B 0.00%
Rum Slim 121.37 KiB 121.37 KiB 0 B 0.00%
Worker 23.63 KiB 23.63 KiB 0 B 0.00%
🚀 CPU Performance

Pending...

🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.53 KiB 26.23 KiB +708 B
RUM - add action 48.11 KiB 49.73 KiB +1.62 KiB
RUM - add timing 23.78 KiB 24.10 KiB +333 B
RUM - add error 53.75 KiB 54.19 KiB +446 B
RUM - start/stop session replay recording 23.51 KiB 23.76 KiB +260 B
RUM - start view 426.72 KiB 424.20 KiB -2.52 KiB
Logs - log message 44.73 KiB 43.63 KiB -1.10 KiB

🔗 RealWorld

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 1, 2025

⚠️ Tests

⚠️ Warnings

🧪 2 Tests failed

cookie getCurrentSite caches the result from Safari 12.1.2 (Mac OS 10.14.6) (Datadog)
Expected spy cookie to have been called 2 times. It was called 0 times.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:50:43 <- /tmp/_karma_webpack_761466/commons.js:48618:49
<Jasmine>
cookie getCurrentSite returns the eTLD+1 for foo.bar.baz.example.com from Safari 12.1.2 (Mac OS 10.14.6) (Datadog)
Expected 'foo.bar.baz.example.com' to be 'example.com'.
<Jasmine>
webpack:///packages/core/src/browser/cookie.spec.ts:24:61 <- /tmp/_karma_webpack_761466/commons.js:48598:108
<Jasmine>

ℹ️ Info

❄️ No new flaky tests detected

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 92.63% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f700dd6 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@renovate renovate bot changed the title 👷 Update dependency express to v5.2.0 [SECURITY] 👷 Update dependency express to v5.2.0 [SECURITY] - autoclosed Dec 2, 2025
@renovate renovate bot closed this Dec 2, 2025
@renovate renovate bot deleted the renovate/npm-express-vulnerability branch December 2, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant