Skip to content

feat: Don't re-init statsd #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Don't re-init statsd #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72939a7
feat: Don't re-init statsd
astuyve Jan 18, 2024
fc77740
Merge branch 'main' into aj/reuse-statsd-client
astuyve Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 3 additions & 14 deletions src/metrics/listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ export class MetricsListener {

if (this.isAgentRunning) {
logDebug(`Using StatsD client`);
if (this.statsDClient) {
return;
}

this.statsDClient = new StatsD({ host: "127.0.0.1", closingFlushInterval: 1 });
return;
Expand All @@ -99,20 +102,6 @@ export class MetricsListener {

await processor.flush();
}
if (this.statsDClient !== undefined) {
logDebug(`Flushing statsD`);

// Make sure all stats are flushed to extension
await new Promise<void>((resolve, reject) => {
this.statsDClient?.close((error) => {
if (error !== undefined) {
reject(error);
}
resolve();
});
});
this.statsDClient = undefined;
}
} catch (error) {
// This can fail for a variety of reasons, from the API not being reachable,
// to KMS key decryption failing.
Expand Down