-
Notifications
You must be signed in to change notification settings - Fork 318
Update system tests pinning trust policy #9941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system tests pinning trust policy #9941
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
🎯 Code Coverage 🔗 Commit SHA: 24a6fa1 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 12 performance improvements and 9 performance regressions! Performance is the same for 34 metrics, 10 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1104349
Total [baseline] (8.822 s) : 0, 8822379
Agent [candidate] (1.049 s) : 0, 1048502
Total [candidate] (8.64 s) : 0, 8639816
section iast
Agent [baseline] (1.241 s) : 0, 1241342
Total [baseline] (9.558 s) : 0, 9558371
Agent [candidate] (1.184 s) : 0, 1184292
Total [candidate] (9.317 s) : 0, 9316963
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (706.344 ms) : 0, 706344
BytebuddyAgent [candidate] (703.376 ms) : 0, 703376
GlobalTracer [baseline] (248.396 ms) : 0, 248396
GlobalTracer [candidate] (248.714 ms) : 0, 248714
AppSec [baseline] (32.327 ms) : 0, 32327
AppSec [candidate] (32.468 ms) : 0, 32468
Debugger [baseline] (68.448 ms) : 0, 68448
Debugger [candidate] (6.387 ms) : 0, 6387
Remote Config [baseline] (638.678 µs) : 0, 639
Remote Config [candidate] (686.929 µs) : 0, 687
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (13.442 ms) : 0, 13442
Flare Poller [baseline] (3.68 ms) : 0, 3680
Flare Poller [candidate] (7.338 ms) : 0, 7338
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (829.391 ms) : 0, 829391
BytebuddyAgent [candidate] (831.097 ms) : 0, 831097
GlobalTracer [baseline] (237.824 ms) : 0, 237824
GlobalTracer [candidate] (236.946 ms) : 0, 236946
IAST [baseline] (28.938 ms) : 0, 28938
IAST [candidate] (32.406 ms) : 0, 32406
AppSec [baseline] (32.112 ms) : 0, 32112
AppSec [candidate] (28.715 ms) : 0, 28715
Debugger [baseline] (65.064 ms) : 0, 65064
Debugger [candidate] (6.043 ms) : 0, 6043
Remote Config [baseline] (549.419 µs) : 0, 549
Remote Config [candidate] (612.888 µs) : 0, 613
Telemetry [baseline] (7.699 ms) : 0, 7699
Telemetry [candidate] (8.04 ms) : 0, 8040
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (4.109 ms) : 0, 4109
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.11 s) : 0, 1109772
Total [baseline] (10.701 s) : 0, 10700843
Agent [candidate] (1.051 s) : 0, 1051498
Total [candidate] (10.831 s) : 0, 10831480
section appsec
Agent [baseline] (1.278 s) : 0, 1278253
Total [baseline] (10.996 s) : 0, 10995611
Agent [candidate] (1.229 s) : 0, 1229066
Total [candidate] (10.938 s) : 0, 10938019
section iast
Agent [baseline] (1.243 s) : 0, 1243335
Total [baseline] (11.282 s) : 0, 11281955
Agent [candidate] (1.182 s) : 0, 1182314
Total [candidate] (11.206 s) : 0, 11206210
section profiling
Agent [baseline] (1.248 s) : 0, 1248484
Total [baseline] (11.031 s) : 0, 11031140
Agent [candidate] (1.199 s) : 0, 1199436
Total [candidate] (10.984 s) : 0, 10984391
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (709.812 ms) : 0, 709812
BytebuddyAgent [candidate] (706.042 ms) : 0, 706042
GlobalTracer [baseline] (249.567 ms) : 0, 249567
GlobalTracer [candidate] (249.531 ms) : 0, 249531
AppSec [baseline] (32.4 ms) : 0, 32400
AppSec [candidate] (32.381 ms) : 0, 32381
Debugger [baseline] (69.048 ms) : 0, 69048
Debugger [candidate] (6.392 ms) : 0, 6392
Remote Config [baseline] (633.943 µs) : 0, 634
Remote Config [candidate] (681.862 µs) : 0, 682
Telemetry [baseline] (8.209 ms) : 0, 8209
Telemetry [candidate] (15.37 ms) : 0, 15370
Flare Poller [baseline] (3.727 ms) : 0, 3727
Flare Poller [candidate] (4.874 ms) : 0, 4874
section appsec
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (728.54 ms) : 0, 728540
BytebuddyAgent [candidate] (732.333 ms) : 0, 732333
GlobalTracer [baseline] (240.647 ms) : 0, 240647
GlobalTracer [candidate] (241.886 ms) : 0, 241886
IAST [baseline] (24.908 ms) : 0, 24908
IAST [candidate] (24.936 ms) : 0, 24936
AppSec [baseline] (174.172 ms) : 0, 174172
AppSec [candidate] (174.835 ms) : 0, 174835
Debugger [baseline] (60.936 ms) : 0, 60936
Debugger [candidate] (6.062 ms) : 0, 6062
Remote Config [baseline] (651.056 µs) : 0, 651
Remote Config [candidate] (659.435 µs) : 0, 659
Telemetry [baseline] (8.35 ms) : 0, 8350
Telemetry [candidate] (7.946 ms) : 0, 7946
Flare Poller [baseline] (3.811 ms) : 0, 3811
Flare Poller [candidate] (3.996 ms) : 0, 3996
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (830.269 ms) : 0, 830269
BytebuddyAgent [candidate] (827.987 ms) : 0, 827987
GlobalTracer [baseline] (238.194 ms) : 0, 238194
GlobalTracer [candidate] (237.399 ms) : 0, 237399
IAST [baseline] (30.561 ms) : 0, 30561
IAST [candidate] (31.885 ms) : 0, 31885
AppSec [baseline] (30.44 ms) : 0, 30440
AppSec [candidate] (29.727 ms) : 0, 29727
Debugger [baseline] (65.896 ms) : 0, 65896
Debugger [candidate] (6.105 ms) : 0, 6105
Remote Config [baseline] (569.497 µs) : 0, 569
Remote Config [candidate] (625.66 µs) : 0, 626
Telemetry [baseline] (7.722 ms) : 0, 7722
Telemetry [candidate] (8.156 ms) : 0, 8156
Flare Poller [baseline] (3.528 ms) : 0, 3528
Flare Poller [candidate] (4.15 ms) : 0, 4150
section profiling
crashtracking [baseline] (1.455 ms) : 0, 1455
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (740.863 ms) : 0, 740863
BytebuddyAgent [candidate] (733.28 ms) : 0, 733280
GlobalTracer [baseline] (224.499 ms) : 0, 224499
GlobalTracer [candidate] (223.062 ms) : 0, 223062
AppSec [baseline] (32.961 ms) : 0, 32961
AppSec [candidate] (32.591 ms) : 0, 32591
Debugger [baseline] (68.538 ms) : 0, 68538
Debugger [candidate] (7.495 ms) : 0, 7495
Remote Config [baseline] (651.495 µs) : 0, 651
Remote Config [candidate] (689.261 µs) : 0, 689
Telemetry [baseline] (8.006 ms) : 0, 8006
Telemetry [candidate] (15.369 ms) : 0, 15369
Flare Poller [baseline] (3.788 ms) : 0, 3788
Flare Poller [candidate] (4.145 ms) : 0, 4145
ProfilingAgent [baseline] (97.267 ms) : 0, 97267
ProfilingAgent [candidate] (111.091 ms) : 0, 111091
Profiling [baseline] (97.856 ms) : 0, 97856
Profiling [candidate] (111.746 ms) : 0, 111746
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~d422f6d41e
dateFormat X
axisFormat %s
section baseline
no_agent (18.229 ms) : 18045, 18412
. : milestone, 18229,
appsec (19.488 ms) : 19288, 19687
. : milestone, 19488,
code_origins (17.55 ms) : 17377, 17723
. : milestone, 17550,
iast (17.687 ms) : 17513, 17862
. : milestone, 17687,
profiling (19.584 ms) : 19384, 19784
. : milestone, 19584,
tracing (17.446 ms) : 17274, 17619
. : milestone, 17446,
section candidate
no_agent (18.994 ms) : 18801, 19187
. : milestone, 18994,
appsec (18.79 ms) : 18600, 18980
. : milestone, 18790,
code_origins (17.723 ms) : 17547, 17900
. : milestone, 17723,
iast (17.736 ms) : 17562, 17910
. : milestone, 17736,
profiling (18.681 ms) : 18495, 18867
. : milestone, 18681,
tracing (17.556 ms) : 17379, 17733
. : milestone, 17556,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~d422f6d41e
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1191
. : milestone, 1180,
iast (3.204 ms) : 3169, 3240
. : milestone, 3204,
iast_FULL (5.956 ms) : 5895, 6016
. : milestone, 5956,
iast_GLOBAL (3.624 ms) : 3569, 3679
. : milestone, 3624,
profiling (2.09 ms) : 2071, 2109
. : milestone, 2090,
tracing (1.863 ms) : 1847, 1879
. : milestone, 1863,
section candidate
no_agent (1.178 ms) : 1167, 1190
. : milestone, 1178,
iast (3.242 ms) : 3196, 3288
. : milestone, 3242,
iast_FULL (5.865 ms) : 5808, 5923
. : milestone, 5865,
iast_GLOBAL (3.559 ms) : 3508, 3611
. : milestone, 3559,
profiling (1.992 ms) : 1974, 2010
. : milestone, 1992,
tracing (1.774 ms) : 1759, 1789
. : milestone, 1774,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1496
. : milestone, 1484,
appsec (4.169 ms) : 3918, 4420
. : milestone, 4169,
iast (2.566 ms) : 2466, 2666
. : milestone, 2566,
iast_GLOBAL (2.609 ms) : 2509, 2709
. : milestone, 2609,
profiling (2.418 ms) : 2332, 2504
. : milestone, 2418,
tracing (2.342 ms) : 2261, 2423
. : milestone, 2342,
section candidate
no_agent (1.488 ms) : 1476, 1500
. : milestone, 1488,
appsec (2.782 ms) : 2699, 2865
. : milestone, 2782,
iast (2.568 ms) : 2468, 2668
. : milestone, 2568,
iast_GLOBAL (2.614 ms) : 2514, 2715
. : milestone, 2614,
profiling (2.409 ms) : 2324, 2495
. : milestone, 2409,
tracing (2.349 ms) : 2268, 2431
. : milestone, 2349,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~24a6fa1bf0, baseline=1.56.0-SNAPSHOT~c17d0e83ec
dateFormat X
axisFormat %s
section baseline
no_agent (14.575 s) : 14575000, 14575000
. : milestone, 14575000,
appsec (14.101 s) : 14101000, 14101000
. : milestone, 14101000,
iast (18.358 s) : 18358000, 18358000
. : milestone, 18358000,
iast_GLOBAL (17.352 s) : 17352000, 17352000
. : milestone, 17352000,
profiling (15.176 s) : 15176000, 15176000
. : milestone, 15176000,
tracing (14.423 s) : 14423000, 14423000
. : milestone, 14423000,
section candidate
no_agent (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
appsec (14.23 s) : 14230000, 14230000
. : milestone, 14230000,
iast (17.821 s) : 17821000, 17821000
. : milestone, 17821000,
iast_GLOBAL (17.158 s) : 17158000, 17158000
. : milestone, 17158000,
profiling (14.367 s) : 14367000, 14367000
. : milestone, 14367000,
tracing (14.193 s) : 14193000, 14193000
. : milestone, 14193000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📝 notes: Make sense as the related pipeline is running on this trigger:
| - 'v[0-9]+.[0-9]+.0' # Trigger on minor release tags (e.g. v1.54.0) |
|
Closing this because there is no need to merge the PR with #9954. Given the prevailing |
|
Sounds good to me. Can you add a quick update to the .github/workflow/README.md about the create-release-branch workflow then? 🙏 |
What Does This Do
Update the trust policy to account for cases when the
job_workflow_refis triggered by a git tag.Motivation
The previous trust policy failed in the latest release (link), so this should fix it. The updates here pass the recommended command For local debugging.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/APMLP-598