Skip to content

add inject datadog attribute config #9943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add inject datadog attribute config #9943

wants to merge 9 commits into from

Conversation

@ojproductions
Copy link
Contributor

@ojproductions ojproductions commented Nov 12, 2025 •
edited
Loading

What Does This Do

  • adds new config <AWS_SERVICE>_INJECT_DATADOG_ATTRIBUTE_ENABLED
    • AWS_SERVICE is one of [SNS,SQS,SFN,EVENTBRIDGE]
  • adds check for config in each service (sns, sqs, sfn, eventbridge) before injecting _datadog to message attributes
  • tests

Motivation

FRSLES-777
APMSVLS-274

tldr: currently, injecting _datadog attribute into Step Function input is disrupting Glue-based automation pipeline, due to schema constraints.

  • if config is set to false, traces will be disconnected, as datadog context is not being propagated
    • ... except for sqs, in which case context is pulled from sqs system attributes which are derived from headers
  • changes include configs for all supported messaging services whereas only SFN is absolutely required to address customer's concern. The others are added for uniformity or in case its useful in the future, but maybe we should only add SFN config for now?

Contributor Checklist

Jira ticket: APMSVLS-247

@datadog-datadog-prod-us1

This comment has been minimized.

Sign in to view
@pr-commenter
Copy link

pr-commenter bot commented Nov 12, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/aws-propagation-config
git_commit_date 1763992896 1764034374
git_commit_sha c8bb444 bac96d0
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.56.0-SNAPSHOT~bac96d07c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1764036413 1764036413
ci_job_id 1255012012 1255012012
ci_pipeline_id 83897793 83897793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-0huxqtv2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-0huxqtv2 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.103 s) : 0, 1102505
Total [baseline] (10.786 s) : 0, 10785598
Agent [candidate] (1.107 s) : 0, 1106810
Total [candidate] (10.817 s) : 0, 10816840
section appsec
Agent [baseline] (1.293 s) : 0, 1292522
Total [baseline] (11.11 s) : 0, 11109698
Agent [candidate] (1.29 s) : 0, 1290446
Total [candidate] (11.096 s) : 0, 11096090
section iast
Agent [baseline] (1.244 s) : 0, 1244264
Total [baseline] (11.256 s) : 0, 11255767
Agent [candidate] (1.253 s) : 0, 1252698
Total [candidate] (11.261 s) : 0, 11260669
section profiling
Agent [baseline] (1.242 s) : 0, 1242459
Total [baseline] (11.071 s) : 0, 11071439
Agent [candidate] (1.233 s) : 0, 1233200
Total [candidate] (11.061 s) : 0, 11060731
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.103 s -
Agent appsec 1.293 s 190.017 ms (17.2%)
Agent iast 1.244 s 141.758 ms (12.9%)
Agent profiling 1.242 s 139.954 ms (12.7%)
Total tracing 10.786 s -
Total appsec 11.11 s 324.101 ms (3.0%)
Total iast 11.256 s 470.17 ms (4.4%)
Total profiling 11.071 s 285.841 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.107 s -
Agent appsec 1.29 s 183.636 ms (16.6%)
Agent iast 1.253 s 145.888 ms (13.2%)
Agent profiling 1.233 s 126.39 ms (11.4%)
Total tracing 10.817 s -
Total appsec 11.096 s 279.251 ms (2.6%)
Total iast 11.261 s 443.829 ms (4.1%)
Total profiling 11.061 s 243.892 ms (2.3%) 
gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.49 ms) : 0, 1490
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (708.585 ms) : 0, 708585
BytebuddyAgent [candidate] (713.028 ms) : 0, 713028
GlobalTracer [baseline] (249.004 ms) : 0, 249004
GlobalTracer [candidate] (248.641 ms) : 0, 248641
AppSec [baseline] (31.901 ms) : 0, 31901
AppSec [candidate] (32.032 ms) : 0, 32032
Debugger [baseline] (64.305 ms) : 0, 64305
Debugger [candidate] (63.959 ms) : 0, 63959
Remote Config [baseline] (643.835 µs) : 0, 644
Remote Config [candidate] (627.235 µs) : 0, 627
Telemetry [baseline] (8.214 ms) : 0, 8214
Telemetry [candidate] (8.34 ms) : 0, 8340
Flare Poller [baseline] (3.702 ms) : 0, 3702
Flare Poller [candidate] (3.762 ms) : 0, 3762
section appsec
crashtracking [baseline] (1.5 ms) : 0, 1500
crashtracking [candidate] (1.48 ms) : 0, 1480
BytebuddyAgent [baseline] (739.171 ms) : 0, 739171
BytebuddyAgent [candidate] (737.155 ms) : 0, 737155
GlobalTracer [baseline] (243.03 ms) : 0, 243030
GlobalTracer [candidate] (242.223 ms) : 0, 242223
AppSec [baseline] (174.556 ms) : 0, 174556
AppSec [candidate] (174.99 ms) : 0, 174990
Debugger [baseline] (61.15 ms) : 0, 61150
Debugger [candidate] (61.708 ms) : 0, 61708
Remote Config [baseline] (686.817 µs) : 0, 687
Remote Config [candidate] (682.468 µs) : 0, 682
Telemetry [baseline] (8.185 ms) : 0, 8185
Telemetry [candidate] (8.363 ms) : 0, 8363
Flare Poller [baseline] (3.902 ms) : 0, 3902
Flare Poller [candidate] (3.954 ms) : 0, 3954
IAST [baseline] (25.169 ms) : 0, 25169
IAST [candidate] (24.895 ms) : 0, 24895
section iast
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (834.008 ms) : 0, 834008
BytebuddyAgent [candidate] (841.056 ms) : 0, 841056
GlobalTracer [baseline] (238.683 ms) : 0, 238683
GlobalTracer [candidate] (239.998 ms) : 0, 239998
AppSec [baseline] (33.337 ms) : 0, 33337
AppSec [candidate] (31.606 ms) : 0, 31606
Debugger [baseline] (61.295 ms) : 0, 61295
Debugger [candidate] (61.239 ms) : 0, 61239
Remote Config [baseline] (557.873 µs) : 0, 558
Remote Config [candidate] (558.068 µs) : 0, 558
Telemetry [baseline] (7.714 ms) : 0, 7714
Telemetry [candidate] (7.693 ms) : 0, 7693
Flare Poller [baseline] (3.538 ms) : 0, 3538
Flare Poller [candidate] (3.555 ms) : 0, 3555
IAST [baseline] (28.828 ms) : 0, 28828
IAST [candidate] (30.521 ms) : 0, 30521
section profiling
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.436 ms) : 0, 1436
BytebuddyAgent [baseline] (740.512 ms) : 0, 740512
BytebuddyAgent [candidate] (735.284 ms) : 0, 735284
GlobalTracer [baseline] (224.027 ms) : 0, 224027
GlobalTracer [candidate] (222.702 ms) : 0, 222702
AppSec [baseline] (32.601 ms) : 0, 32601
AppSec [candidate] (32.158 ms) : 0, 32158
Debugger [baseline] (63.831 ms) : 0, 63831
Debugger [candidate] (63.055 ms) : 0, 63055
Remote Config [baseline] (669.15 µs) : 0, 669
Remote Config [candidate] (650.89 µs) : 0, 651
Telemetry [baseline] (8.033 ms) : 0, 8033
Telemetry [candidate] (8.006 ms) : 0, 8006
Flare Poller [baseline] (3.872 ms) : 0, 3872
Flare Poller [candidate] (3.779 ms) : 0, 3779
ProfilingAgent [baseline] (97.944 ms) : 0, 97944
ProfilingAgent [candidate] (96.955 ms) : 0, 96955
Profiling [baseline] (98.536 ms) : 0, 98536
Profiling [candidate] (97.58 ms) : 0, 97580
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1103620
Total [baseline] (8.867 s) : 0, 8867122
Agent [candidate] (1.101 s) : 0, 1100626
Total [candidate] (8.821 s) : 0, 8821141
section iast
Agent [baseline] (1.241 s) : 0, 1240685
Total [baseline] (9.544 s) : 0, 9543969
Agent [candidate] (1.247 s) : 0, 1247401
Total [candidate] (9.565 s) : 0, 9564854
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.104 s -
Agent iast 1.241 s 137.065 ms (12.4%)
Total tracing 8.867 s -
Total iast 9.544 s 676.847 ms (7.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.101 s -
Agent iast 1.247 s 146.775 ms (13.3%)
Total tracing 8.821 s -
Total iast 9.565 s 743.713 ms (8.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.506 ms) : 0, 1506
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (711.201 ms) : 0, 711201
BytebuddyAgent [candidate] (707.954 ms) : 0, 707954
GlobalTracer [baseline] (248.844 ms) : 0, 248844
GlobalTracer [candidate] (248.938 ms) : 0, 248938
AppSec [baseline] (31.77 ms) : 0, 31770
AppSec [candidate] (31.894 ms) : 0, 31894
Debugger [baseline] (63.029 ms) : 0, 63029
Debugger [candidate] (63.113 ms) : 0, 63113
Remote Config [baseline] (631.15 µs) : 0, 631
Remote Config [candidate] (618.715 µs) : 0, 619
Telemetry [baseline] (8.112 ms) : 0, 8112
Telemetry [candidate] (8.217 ms) : 0, 8217
Flare Poller [baseline] (3.614 ms) : 0, 3614
Flare Poller [candidate] (3.645 ms) : 0, 3645
section iast
crashtracking [baseline] (1.483 ms) : 0, 1483
crashtracking [candidate] (1.504 ms) : 0, 1504
BytebuddyAgent [baseline] (833.052 ms) : 0, 833052
BytebuddyAgent [candidate] (837.921 ms) : 0, 837921
GlobalTracer [baseline] (237.413 ms) : 0, 237413
GlobalTracer [candidate] (238.393 ms) : 0, 238393
AppSec [baseline] (32.345 ms) : 0, 32345
AppSec [candidate] (35.28 ms) : 0, 35280
Debugger [baseline] (60.282 ms) : 0, 60282
Debugger [candidate] (60.645 ms) : 0, 60645
Remote Config [baseline] (564.311 µs) : 0, 564
Remote Config [candidate] (564.071 µs) : 0, 564
Telemetry [baseline] (7.693 ms) : 0, 7693
Telemetry [candidate] (7.668 ms) : 0, 7668
Flare Poller [baseline] (3.511 ms) : 0, 3511
Flare Poller [candidate] (3.505 ms) : 0, 3505
IAST [baseline] (29.486 ms) : 0, 29486
IAST [candidate] (26.951 ms) : 0, 26951
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/aws-propagation-config
git_commit_date 1763992896 1764034374
git_commit_sha c8bb444 bac96d0
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.56.0-SNAPSHOT~bac96d07c1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1764036761 1764036761
ci_job_id 1255012013 1255012013
ci_pipeline_id 83897793 83897793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-wbytiubm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-wbytiubm 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load worse
[+142.005µs; +262.103µs] or [+5.253%; +9.695%]		 unsure
[+118.263µs; +557.767µs] or [+1.521%; +7.172%]		 unstable
[-212.660op/s; +70.722op/s] or [-16.060%; +5.341%]		 2.906ms 8.115ms 1253.156op/s 2.704ms 7.777ms 1324.125op/s
scenario:load:petclinic:iast:high_load worse
[+0.984ms; +1.769ms] or [+5.691%; +10.232%]		 worse
[+1.264ms; +2.709ms] or [+4.525%; +9.701%]		 unstable
[-43.685op/s; +6.560op/s] or [-16.499%; +2.478%]		 18.669ms 29.918ms 246.219op/s 17.292ms 27.931ms 264.781op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.214 ms) : 1203, 1226
.   : milestone, 1214,
iast (3.282 ms) : 3238, 3325
.   : milestone, 3282,
iast_FULL (5.807 ms) : 5749, 5865
.   : milestone, 5807,
iast_GLOBAL (3.461 ms) : 3411, 3510
.   : milestone, 3461,
profiling (2.21 ms) : 2189, 2230
.   : milestone, 2210,
tracing (1.815 ms) : 1798, 1831
.   : milestone, 1815,
section candidate
no_agent (1.233 ms) : 1220, 1246
.   : milestone, 1233,
iast (3.286 ms) : 3239, 3332
.   : milestone, 3286,
iast_FULL (5.671 ms) : 5615, 5727
.   : milestone, 5671,
iast_GLOBAL (3.66 ms) : 3606, 3714
.   : milestone, 3660,
profiling (2.033 ms) : 2016, 2051
.   : milestone, 2033,
tracing (1.785 ms) : 1771, 1798
.   : milestone, 1785,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.214 ms [1.203 ms, 1.226 ms] -
iast 3.282 ms [3.238 ms, 3.325 ms] 2.067 ms (170.2%)
iast_FULL 5.807 ms [5.749 ms, 5.865 ms] 4.593 ms (378.2%)
iast_GLOBAL 3.461 ms [3.411 ms, 3.51 ms] 2.246 ms (184.9%)
profiling 2.21 ms [2.189 ms, 2.23 ms] 995.073 µs (81.9%)
tracing 1.815 ms [1.798 ms, 1.831 ms] 600.354 µs (49.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.233 ms [1.22 ms, 1.246 ms] -
iast 3.286 ms [3.239 ms, 3.332 ms] 2.053 ms (166.5%)
iast_FULL 5.671 ms [5.615 ms, 5.727 ms] 4.438 ms (360.0%)
iast_GLOBAL 3.66 ms [3.606 ms, 3.714 ms] 2.427 ms (196.9%)
profiling 2.033 ms [2.016 ms, 2.051 ms] 800.656 µs (64.9%)
tracing 1.785 ms [1.771 ms, 1.798 ms] 551.903 µs (44.8%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.336 ms) : 19139, 19532
.   : milestone, 19336,
appsec (18.501 ms) : 18314, 18687
.   : milestone, 18501,
code_origins (17.557 ms) : 17382, 17732
.   : milestone, 17557,
iast (17.621 ms) : 17451, 17792
.   : milestone, 17621,
profiling (18.53 ms) : 18344, 18716
.   : milestone, 18530,
tracing (17.406 ms) : 17229, 17582
.   : milestone, 17406,
section candidate
no_agent (18.333 ms) : 18145, 18521
.   : milestone, 18333,
appsec (19.171 ms) : 18976, 19366
.   : milestone, 19171,
code_origins (17.72 ms) : 17548, 17893
.   : milestone, 17720,
iast (18.957 ms) : 18765, 19148
.   : milestone, 18957,
profiling (18.702 ms) : 18516, 18888
.   : milestone, 18702,
tracing (17.628 ms) : 17452, 17803
.   : milestone, 17628,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.336 ms [19.139 ms, 19.532 ms] -
appsec 18.501 ms [18.314 ms, 18.687 ms] -835.047 µs (-4.3%)
code_origins 17.557 ms [17.382 ms, 17.732 ms] -1.779 ms (-9.2%)
iast 17.621 ms [17.451 ms, 17.792 ms] -1.714 ms (-8.9%)
profiling 18.53 ms [18.344 ms, 18.716 ms] -805.642 µs (-4.2%)
tracing 17.406 ms [17.229 ms, 17.582 ms] -1.93 ms (-10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.333 ms [18.145 ms, 18.521 ms] -
appsec 19.171 ms [18.976 ms, 19.366 ms] 838.21 µs (4.6%)
code_origins 17.72 ms [17.548 ms, 17.893 ms] -612.429 µs (-3.3%)
iast 18.957 ms [18.765 ms, 19.148 ms] 624.088 µs (3.4%)
profiling 18.702 ms [18.516 ms, 18.888 ms] 369.143 µs (2.0%)
tracing 17.628 ms [17.452 ms, 17.803 ms] -704.829 µs (-3.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master onzia/aws-propagation-config
git_commit_date 1763992896 1764034374
git_commit_sha c8bb444 bac96d0
release_version 1.57.0-SNAPSHOT~c8bb44440b 1.56.0-SNAPSHOT~bac96d07c1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1764036497 1764036497
ci_job_id 1255012014 1255012014
ci_pipeline_id 83897793 83897793
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-tya7mqpy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-tya7mqpy 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.933 s) : 14933000, 14933000
.   : milestone, 14933000,
appsec (14.525 s) : 14525000, 14525000
.   : milestone, 14525000,
iast (18.037 s) : 18037000, 18037000
.   : milestone, 18037000,
iast_GLOBAL (18.029 s) : 18029000, 18029000
.   : milestone, 18029000,
profiling (14.696 s) : 14696000, 14696000
.   : milestone, 14696000,
tracing (14.746 s) : 14746000, 14746000
.   : milestone, 14746000,
section candidate
no_agent (15.317 s) : 15317000, 15317000
.   : milestone, 15317000,
appsec (14.658 s) : 14658000, 14658000
.   : milestone, 14658000,
iast (18.608 s) : 18608000, 18608000
.   : milestone, 18608000,
iast_GLOBAL (17.834 s) : 17834000, 17834000
.   : milestone, 17834000,
profiling (15.138 s) : 15138000, 15138000
.   : milestone, 15138000,
tracing (14.649 s) : 14649000, 14649000
.   : milestone, 14649000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.933 s [14.933 s, 14.933 s] -
appsec 14.525 s [14.525 s, 14.525 s] -408.0 ms (-2.7%)
iast 18.037 s [18.037 s, 18.037 s] 3.104 s (20.8%)
iast_GLOBAL 18.029 s [18.029 s, 18.029 s] 3.096 s (20.7%)
profiling 14.696 s [14.696 s, 14.696 s] -237.0 ms (-1.6%)
tracing 14.746 s [14.746 s, 14.746 s] -187.0 ms (-1.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.317 s [15.317 s, 15.317 s] -
appsec 14.658 s [14.658 s, 14.658 s] -659.0 ms (-4.3%)
iast 18.608 s [18.608 s, 18.608 s] 3.291 s (21.5%)
iast_GLOBAL 17.834 s [17.834 s, 17.834 s] 2.517 s (16.4%)
profiling 15.138 s [15.138 s, 15.138 s] -179.0 ms (-1.2%)
tracing 14.649 s [14.649 s, 14.649 s] -668.0 ms (-4.4%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~bac96d07c1, baseline=1.57.0-SNAPSHOT~c8bb44440b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.47 ms) : 2418, 2522
.   : milestone, 2470,
iast (2.227 ms) : 2162, 2292
.   : milestone, 2227,
iast_GLOBAL (2.265 ms) : 2199, 2330
.   : milestone, 2265,
profiling (2.081 ms) : 2028, 2134
.   : milestone, 2081,
tracing (2.056 ms) : 2004, 2107
.   : milestone, 2056,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (2.468 ms) : 2416, 2520
.   : milestone, 2468,
iast (2.216 ms) : 2152, 2281
.   : milestone, 2216,
iast_GLOBAL (2.259 ms) : 2194, 2324
.   : milestone, 2259,
profiling (2.457 ms) : 2250, 2664
.   : milestone, 2457,
tracing (2.049 ms) : 1998, 2100
.   : milestone, 2049,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.47 ms [2.418 ms, 2.522 ms] 992.282 µs (67.1%)
iast 2.227 ms [2.162 ms, 2.292 ms] 748.53 µs (50.6%)
iast_GLOBAL 2.265 ms [2.199 ms, 2.33 ms] 786.722 µs (53.2%)
profiling 2.081 ms [2.028 ms, 2.134 ms] 603.284 µs (40.8%)
tracing 2.056 ms [2.004 ms, 2.107 ms] 577.667 µs (39.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 2.468 ms [2.416 ms, 2.52 ms] 993.269 µs (67.4%)
iast 2.216 ms [2.152 ms, 2.281 ms] 741.916 µs (50.3%)
iast_GLOBAL 2.259 ms [2.194 ms, 2.324 ms] 784.26 µs (53.2%)
profiling 2.457 ms [2.25 ms, 2.664 ms] 982.661 µs (66.6%)
tracing 2.049 ms [1.998 ms, 2.1 ms] 574.23 µs (38.9%)

@ojproductions ojproductions changed the title Onzia/aws propagation config add inject datadog attribute config Nov 24, 2025
@ojproductions ojproductions added comp: config Configuration and removed comp: remote config Configuration at Runtime labels Nov 24, 2025
@ojproductions ojproductions marked this pull request as ready for review November 24, 2025 17:35
@ojproductions ojproductions requested review from a team as code owners November 24, 2025 17:35
@ojproductions ojproductions requested a review from a team as a code owner November 24, 2025 17:53
@ojproductions ojproductions requested review from amarziali and removed request for a team November 24, 2025 17:53
mhlidd
mhlidd reviewed Nov 24, 2025
View reviewed changes
Copy link
Contributor

@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments/nits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhlidd mhlidd mhlidd left review comments

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@amarziali amarziali Awaiting requested review from amarziali amarziali is a code owner automatically assigned from DataDog/apm-lang-platform-java

At least 1 approving review is required to merge this pull request.

Assignees

@mhlidd mhlidd

Labels

comp: config Configuration type: feature request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ojproductions @mhlidd