chore(aap): appsec tests in appsec files #15155
Conversation
christophe-papazian
added
changelog/no-changelog
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 248 ± 5 ms. The average import time from base is: 263 ± 7 ms. The import time difference between this PR and base is: -14.8 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate christophe-papazian/put_appsec_tests_in_their_own_files (e6099e7) with baseline main (08d3021) 🟡 Near SLO Breach (5 suites)🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 16.677ms (SLO: <19.850ms 📉 -16.0%) vs baseline: +1.8% Memory: ✅ 65.795MB (SLO: <66.500MB 🟡 -1.1%) vs baseline: +5.2% ✅ errortracking-enabled-userTime: ✅ 16.361ms (SLO: <19.400ms 📉 -15.7%) vs baseline: +0.1% Memory: ✅ 65.698MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +5.1% ✅ tracer-enabledTime: ✅ 16.305ms (SLO: <19.450ms 📉 -16.2%) vs baseline: -0.5% Memory: ✅ 65.695MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.8% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.073ms (SLO: <2.300ms -9.9%) vs baseline: +0.3% Memory: ✅ 52.494MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 2.087ms (SLO: <2.250ms -7.2%) vs baseline: +0.9% Memory: ✅ 52.475MB (SLO: <53.500MB 🟡 -1.9%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.094ms (SLO: <2.300ms -9.0%) vs baseline: +1.5% Memory: ✅ 52.337MB (SLO: <53.500MB -2.2%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.585ms (SLO: <4.750ms -3.5%) vs baseline: ~same Memory: ✅ 62.104MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.612ms (SLO: <6.750ms -2.0%) vs baseline: -0.2% Memory: ✅ 62.103MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.587ms (SLO: <4.750ms -3.4%) vs baseline: -0.2% Memory: ✅ 62.068MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: ~same Memory: ✅ 45.198MB (SLO: <47.000MB -3.8%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.853ms (SLO: <2.000ms -7.4%) vs baseline: -0.3% Memory: ✅ 41.831MB (SLO: <49.000MB 📉 -14.6%) vs baseline: +5.0% ✅ profilerTime: ✅ 1.914ms (SLO: <2.100ms -8.9%) vs baseline: -0.1% Memory: ✅ 46.514MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 52.396MB (SLO: <53.500MB -2.1%) vs baseline: +4.6% ✅ tracerTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 52.314MB (SLO: <53.500MB -2.2%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: +0.2% Memory: ✅ 53.994MB (SLO: <60.000MB 📉 -10.0%) vs baseline: +4.7% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.722ms (SLO: <47.150ms 📉 -17.9%) vs baseline: +0.1% Memory: ✅ 36.399MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +4.6% ✅ add-metricsTime: ✅ 259.743ms (SLO: <344.800ms 📉 -24.7%) vs baseline: ~same Memory: ✅ 40.659MB (SLO: <47.500MB 📉 -14.4%) vs baseline: +4.5% ✅ add-tagsTime: ✅ 316.119ms (SLO: <321.000ms 🟡 -1.5%) vs baseline: -0.2% Memory: ✅ 40.757MB (SLO: <47.500MB 📉 -14.2%) vs baseline: +4.9% ✅ get-contextTime: ✅ 78.567ms (SLO: <92.350ms 📉 -14.9%) vs baseline: -0.3% Memory: ✅ 36.738MB (SLO: <46.500MB 📉 -21.0%) vs baseline: +4.8% ✅ is-recordingTime: ✅ 36.179ms (SLO: <44.500ms 📉 -18.7%) vs baseline: +0.6% Memory: ✅ 36.215MB (SLO: <47.500MB 📉 -23.8%) vs baseline: +5.1% ✅ record-exceptionTime: ✅ 57.129ms (SLO: <67.650ms 📉 -15.6%) vs baseline: ~same Memory: ✅ 36.818MB (SLO: <47.000MB 📉 -21.7%) vs baseline: +4.9% ✅ set-statusTime: ✅ 42.736ms (SLO: <50.400ms 📉 -15.2%) vs baseline: +0.3% Memory: ✅ 36.131MB (SLO: <47.000MB 📉 -23.1%) vs baseline: +5.0% ✅ startTime: ✅ 35.570ms (SLO: <43.450ms 📉 -18.1%) vs baseline: ~same Memory: ✅ 36.250MB (SLO: <47.000MB 📉 -22.9%) vs baseline: +5.1% ✅ start-finishTime: ✅ 82.044ms (SLO: <88.000ms -6.8%) vs baseline: +0.4% Memory: ✅ 34.092MB (SLO: <46.500MB 📉 -26.7%) vs baseline: +4.9% ✅ start-finish-telemetryTime: ✅ 83.560ms (SLO: <89.000ms -6.1%) vs baseline: +0.1% Memory: ✅ 33.974MB (SLO: <46.500MB 📉 -26.9%) vs baseline: +4.9% ✅ update-nameTime: ✅ 37.076ms (SLO: <45.150ms 📉 -17.9%) vs baseline: +0.9% Memory: ✅ 36.372MB (SLO: <47.000MB 📉 -22.6%) vs baseline: +5.0% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 308.593ms (SLO: <320.950ms -3.9%) vs baseline: ~same Memory: ✅ 32.696MB (SLO: <34.500MB -5.2%) vs baseline: +4.8% ✅ deep-profiledTime: ✅ 327.741ms (SLO: <359.150ms -8.7%) vs baseline: -0.2% Memory: ✅ 38.269MB (SLO: <39.000MB 🟡 -1.9%) vs baseline: +4.9% ✅ mediumTime: ✅ 7.008ms (SLO: <7.400ms -5.3%) vs baseline: +0.2% Memory: ✅ 31.516MB (SLO: <34.000MB -7.3%) vs baseline: +5.0% ✅ shallowTime: ✅ 0.941ms (SLO: <1.050ms 📉 -10.4%) vs baseline: +0.1% Memory: ✅ 31.536MB (SLO: <34.000MB -7.2%) vs baseline: +4.9%
|
…' of github.com:DataDog/dd-trace-py into christophe-papazian/put_appsec_tests_in_their_own_files
christophe-papazian
requested review from
emmettbutler,
mabdinur and
rachelyangdog
and removed request for
rachelyangdog
|
LGTM @christophe-papazian! |
emmettbutler
left a comment
emmettbutler
left a comment
There was a problem hiding this comment.
very nice, thank you
mabdinur
left a comment
mabdinur
left a comment
There was a problem hiding this comment.
Left some nits. Overall I love this change. In a follow up PR can we also introduce a new api for configuring asm/iast that doesn't require importing the global tracer?
Something like would be nice:
def configure_security_products(...):
****
Or we can just avoid exposing a programmatic api for enabling asm/iast (my preference). I think this would better align with next gen efforts
…ut_appsec_tests_in_their_own_files
christophe-papazian
deleted the
christophe-papazian/put_appsec_tests_in_their_own_files
branch
## Description part 2 of #15155 - removing appsec reference from non appsec specific tests - moving appsec tests in their own files - shared test files ownership to the python guild APPSEC-59813
Description
Basically, making sure we are accountable for ASM/AAP.
This PR will be followed by another one on the same topic (to not create huge PR)
APPSEC-59813