Skip to content

Conversation

@brettlangdon
Copy link
Member

Description

A few more Span attributes/methods to deprecate in 4.0.

Testing

Risks

Additional Notes

@brettlangdon brettlangdon requested review from a team as code owners November 7, 2025 19:52
@brettlangdon brettlangdon enabled auto-merge (squash) November 7, 2025 19:52
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

CODEOWNERS have been resolved as:

releasenotes/notes/deprecate-span-finished-finish-with-ancestors-c75633a9baaa9463.yaml  @DataDog/apm-python
ddtrace/_trace/span.py                                                  @DataDog/apm-sdk-capabilities-python
ddtrace/contrib/internal/aws_lambda/patch.py                            @DataDog/apm-serverless

Copy link
Contributor

@Yun-Kim Yun-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in release note but lgtm

- |
tracing: ``Span.finished`` setter is deprecated, use ``Span.finish()`` method instead.
- |
tracing: ``Span.finished_with_ancestors()`` is deprecated with no alternative.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tracing: ``Span.finished_with_ancestors()`` is deprecated with no alternative.
tracing: ``Span.finish_with_ancestors()`` is deprecated with no alternative.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 237 ± 2 ms.

The average import time from base is: 239 ± 2 ms.

The import time difference between this PR and base is: -1.86 ± 0.09 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 1.969 ms (0.83%)
ddtrace.bootstrap.sitecustomize 1.260 ms (0.53%)
ddtrace.bootstrap.preload 1.260 ms (0.53%)
ddtrace.internal.remoteconfig.client 0.610 ms (0.26%)
ddtrace 0.709 ms (0.30%)
ddtrace.internal._unpatched 0.060 ms (0.03%)
subprocess 0.031 ms (0.01%)
contextlib 0.031 ms (0.01%)
json 0.029 ms (0.01%)
json.decoder 0.029 ms (0.01%)
re 0.029 ms (0.01%)
enum 0.029 ms (0.01%)
types 0.029 ms (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants