-
Notifications
You must be signed in to change notification settings - Fork 467
chore(tracing): deprecate Span.finished setter and Span.finish_with_ancestors() #15187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in release note but lgtm
| - | | ||
| tracing: ``Span.finished`` setter is deprecated, use ``Span.finish()`` method instead. | ||
| - | | ||
| tracing: ``Span.finished_with_ancestors()`` is deprecated with no alternative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| tracing: ``Span.finished_with_ancestors()`` is deprecated with no alternative. | |
| tracing: ``Span.finish_with_ancestors()`` is deprecated with no alternative. |
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 237 ± 2 ms. The average import time from base is: 239 ± 2 ms. The import time difference between this PR and base is: -1.86 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
Description
A few more Span attributes/methods to deprecate in 4.0.
Testing
Risks
Additional Notes