-
Notifications
You must be signed in to change notification settings - Fork 26
Fix gallery disappearing on hover: Replace ineffective scroll event fix with comprehensive E2E testing #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
12
commits into
master
Choose a base branch
from
copilot/fix-101
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+112
−8
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dbdca53
Initial plan
Copilot 7844096
Initial analysis of gallery disappearing on mousehover issue
Copilot 9ce631e
Fix gallery disappearing on mousehover by preventing unnecessary scro…
Copilot 2e6db6b
Remove package-lock.json and restore original yarn.lock and tests/log…
Copilot 82f36ac
Fix prettier formatting issues in test file
Copilot 0818280
Restore tests/logs/.gitkeep file to original state
Copilot d24974e
Investigate and respond to feedback about scroll vs resize event diag…
Copilot bcd81cb
Restore tests/logs/.gitkeep file again
Copilot 14c789a
Add comprehensive tests proving resizing class is the likely cause of…
Copilot d58bcc9
Fix test to actually test hover transform mechanism instead of just m…
Copilot 20c4bff
Remove meaningless circular test that only proves method calls change…
Copilot 9fc63ad
Replace meaningless hover unit tests with proper E2E test
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.