Filter higherrank results if not allowed #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases (see "Leptotyphlops conjunctus"), the first result from
get_gbifid_is a "HIGHERRANK" match, even when there are also exact matches. Currently the function doesn't filter out this match, and if it has an "ACCEPTED" status, it'll be selected by the function, but then filtered out later, resulting in "No matching species concept!" even though there may have been species matches. This filters out the "HIGHERRANK" matches beforehand ifhigherrank = TRUEto prevent this.I also added some additional checks in the
ifloops to make sure there are still matches before we check them for various things.