-
-
Notifications
You must be signed in to change notification settings - Fork 23k
feat: handle 429 errors and redirect to rate-limited page #5440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @0xi4o, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the application's robustness and user experience by gracefully handling API rate-limiting scenarios. It introduces a new user interface to inform users about rate limits and provides a mechanism to automatically redirect them to this page when a 429 error occurs, along with a countdown before they can retry their actions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces handling for 429 'Too Many Requests' errors by redirecting the user to a new rate-limited page. The changes include adding the new page and route, and updating the global error handler. My review includes feedback on improving the robustness of parsing the Retry-After header, fixing a memory leak in the countdown timer on the new page, and a suggestion to improve the user experience by using a more appropriate icon.
chungyau97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen when LLM provider returns a 429 error?
Will user be redirected to this 429 page or The error message (e.g., “429: Rate limit exceeded”) will appear directly in the chat box?
Uh oh!
There was an error while loading. Please reload this page.