Skip to content

add step! #1833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FelixBenning wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add step! #1833

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2fa1c7c
add step!
FelixBenning Jan 13, 2022
c8f147b
add NEWS.md
FelixBenning Jan 13, 2022
1f34fd7
use withgradient instead
FelixBenning Jan 16, 2022
0765010
apply suggested changes to docstring
FelixBenning Jan 18, 2022
5b4fc17
apply suggested changes to docstring
FelixBenning Jan 18, 2022
12a8284
rename step! to optimstep!
FelixBenning Jan 18, 2022
68a0590
add optimstep! to docs
FelixBenning Jan 18, 2022
c321e4f
update optimisers section
FelixBenning Jan 18, 2022
bb7b5c5
apostrophes
FelixBenning Jan 18, 2022
cc31acb
bracket at the end of the sentence
FelixBenning Jan 18, 2022
5220fe9
Update NEWS.md
FelixBenning May 24, 2022
fa68993
Update src/optimise/Optimise.jl
FelixBenning May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/optimise/train.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using Juno
import Zygote: Params, gradient
import Zygote: Params, withgradient

"""
update!(x, x̄)
Expand Down Expand Up @@ -102,8 +102,9 @@ for d in data

"""
function step!(loss, params, opt)
gs = gradient(loss, params)
val, gs = withgradient(loss, params)
update!(opt, params, gs)
return val, gs
end

"""
Expand Down