Skip to content

Allow RequestParam and FileParam to target class #2405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Allow RequestParam and FileParam to target class #2405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
386c187
Allow request and file params to be on class
flohw Mar 7, 2024
7e605cc
Add annotation for compatibility
flohw Mar 7, 2024
721e821
Fix Target annotation
flohw Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Controller/Annotations/FileParam.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
*
* @Annotation
* @NamedArgumentConstructor
* @Target("METHOD")
* @Target({"METHOD", "CLASS"})
*
* @author Ener-Getick <egetick@gmail.com>
*/
#[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_METHOD)]
#[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_METHOD | \Attribute::TARGET_CLASS)]
class FileParam extends AbstractParam
{
/** @var bool */
Expand Down
4 changes: 2 additions & 2 deletions Controller/Annotations/RequestParam.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
*
* @Annotation
* @NamedArgumentConstructor
* @Target("METHOD")
* @Target({"METHOD", "CLASS"})
*
* @author Jordi Boggiano <j.boggiano@seld.be>
* @author Boris Guéry <guery.b@gmail.com>
*/
#[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_METHOD)]
#[\Attribute(\Attribute::IS_REPEATABLE | \Attribute::TARGET_METHOD | \Attribute::TARGET_CLASS)]
class RequestParam extends AbstractScalarParam
{
/** @var bool */
Expand Down