Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beet is upgrading to Pydantic v2. I wanted to make sure that the changes on the
betabranch don't break anything so I decided to try to build gm4 with it. And with this PR I'm successfully building everything:$ uv run beet -p beet-release.yamlThe
devcommand seems to work as well.Nearly all of the changes I had to make were related to Pydantic. Some things to note:
overlay_formatsisNone). This is most likely from recent changes on beet's main branch that weren't accounted for in gm4 yet.skin_cache.jsongot updated, not sure why?Nonedefault values.TemplateOptions,TransformOptions, andContainerGuiOptionsto a sort of dynamic discriminated union.serialize_as_any=True.ValidationErrorchanged and I couldn't easily convert the code responsible for aggregating and prefixing errors fromNestedModelDatavalidation. Now, if there are errors, only the first one is shown.Feel free to polish this up, or just use the PR as a guide and completely re-do things your way.