-
Notifications
You must be signed in to change notification settings - Fork 1
Figure 3: Backgroundmaps - coast, remote dataset, tilemap, 3-D - relief of Iceland #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/GenericMappingTools/pygmt-paper-figures/pull/8 |
|
@yvonnefroehlich What about extending this example to include more basemap types? Below are four basemaps that can fit in a 2x2 subplot layout.
Users unfamiliar with GMT can get a first impression of the types of basemaps PyGMT offers, while experienced GMT users can discover that PyGMT supports tilemap-style basemaps. Please let me know that you think and I'd like to help if you don't have time to work on it. |
There is already an example for
Just tried the crustal age dataset, as this one is interesting for the area of Island.
I just added the other two maps for the region Island. Feel free to modify the codes, including choosing another area or dataset and re-ordering the maps. |
I prefer to use the following figure generated by #4 as our Figure 2. It's similar to the one in PR #1, but for a global region. Then in this example, a regional coastline-style base map makes more sense.
Thanks. My suggestions are:
|
Do you want a proper satellite image (e.g. Sentinel-3 or MODIS), or just use Blue Marble |
|
@yvonnefroehlich In panel (a) or (b), could you please add a scale bar or a directional rose, and also use the Box class adding a box around it. This will be an example demonstrating the Box class introduded in v0.17.0. |
Maybe just use UTM projection to demonstrate that GMT supports both lon/lat and UTM? |
|
@yvonnefroehlich Here are my three suggestions:
I prefer to removing these variables to keep the script simpler and more readable. |
|
It seems you accidently deleted all the codes in the notebook. Please add it back. |
This reverts commit 4468e4b.
Oh, no - strange, do not know what I did 🙁. But the codes should be back in commit d3fa667. |
@yvonnefroehlich When working on the manuscript, I feel this is not a good place to introduce the |
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Fig3_PyGMT_backgrounds.py
Outdated
| fig.colorbar(frame=["xa500f250+lElevation", "y+lm"], position="JRM", shading=True) | ||
|
|
||
| # Bottom right | ||
| fig.basemap(region=region, projection="M?", perspective=(-150, 25), panel=3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the Figure.basemap call here? Or merge it into Figure.grdview.
Actually I'm not sure if the use of region is correct here, since in a 3-D perspective view, region may need six values rather than four.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I testded this locally and for me it looks like that the output figure remains unchanged. I think this can get problematic for Figure.plot3d and six values need to be passed to the region parameter.
I like about using Figure.basemap and Figure.grdview that we can show that for the first method the users has to define the perspective parameter, but for the following methods perspective=True can be used.
|
I guess this PR is good to merge, right? @yvonnefroehlich Could you please copy the Python script to Jupyter Notebook and remove the PNG and .py files? |
Yes, I think this figure looks good and we can move on with the remaining figure. Can still make PRs for details and making things consistent in the end. |
|
Could you also please remove the PNG and clean the notebook output |
|
Please also remove the execution permission from .ipynb. |
|
Could you please also remove the image included in the Jupyter Notebook? We definitely will update the script and the image later, so keeping them in the notebooks will increase the repo size quickly. We will include them when the scripts are finalized. |

This PR adds a JN for backgroundmaps:
Figure.coast: land and water masses, shorelinesFigure.grdimagecontextilyand plot it viaFigure.tilemapsFigure.grdviewPreview:
