Skip to content

Fix author list of PyGMT v0.7.0 #2003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seisman merged 1 commit into from
Jul 11, 2022
Merged

Fix author list of PyGMT v0.7.0 #2003

seisman merged 1 commit into from
Jul 11, 2022

Conversation

@yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jul 11, 2022

Description of proposed changes

Fixes #1981 (comment) and #2002

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

maxrjones
maxrjones approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting this fix!

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jul 11, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 11, 2022
@seisman seisman merged commit 1fcbc93 into GenericMappingTools:main Jul 11, 2022
@yvonnefroehlich yvonnefroehlich deleted the fix-author-list-of-pygmt-v0.7.0 branch July 12, 2022 06:33
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@yvonnefroehlich
Add Andre Belem and Yvonne Fröhlich to author list (GenericMappingToo…
2212ce7 
…ls#2003)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxrjones maxrjones maxrjones approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@yvonnefroehlich @maxrjones @seisman