Skip to content

Conversation

@yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR aims to use the GMT-related term annotations in the gallery example Color points by categories. When making the changes in PR #1933 I used labels. This is not precise and inconsistent to the description for the colorbar added in PR #1267. I also renamed the corresponding variable. If there are any preferences or convention regarding variable names, I am happy to adjust or improve this.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Aug 14, 2022
@seisman seisman added this to the 0.8.0 milestone Aug 14, 2022
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Aug 14, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 15, 2022
@seisman seisman merged commit 902181f into main Aug 15, 2022
@seisman seisman deleted the correct-frame-terminology-in-pointscatego branch August 15, 2022 01:09
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants