Add PyArrow as an optional dependency #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
enhancement
michaelgrund
approved these changes
Nov 6, 2024
michaelgrund
added
final review call
Member
There was a problem hiding this comment.
Probably we also need to update the installation guide.
Edit: Sorry, I read incorrectly. In the dev version it's already included in the installation guide
Line 177 in 4498f71
yvonnefroehlich
approved these changes
Nov 6, 2024
weiji14
approved these changes
Nov 6, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
removed
the
final review call
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
added a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
added a commit
that referenced
this pull request
Nov 19, 2024
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're working towards supporting more PyArrow data types in #2800. I think it makes sense to explicitly add it as an optional dependency, just like what we're doing to contexily, geopandas, ipython and rioxarray.
FYI, we already mentioned
pyarrowas an optional dependency on the PyGMT Ecosystem page and recommended to install it in #3506.This PR supersedes some changes in PR #2933.