-
Notifications
You must be signed in to change notification settings - Fork 234
Support passing string type numbers, geographic coordinates and datetimes #975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
416cf8f
Initial support for passing strings to GMT via GMT_Put_Vectors
seisman f058465
Add more tests
seisman 24ad0af
Add clib.Session.put_strings to API docs
seisman 80c1062
Merge branch 'master' into put-vector-text
seisman 10fb939
Merge branch 'master' into put-vector-text
seisman bf7587c
Improve the tests for datetime strings
seisman c1585a9
Remove unused expected_dtypes
seisman 6ba4d5c
Add more comments to the test
seisman e30b637
Merge branch 'master' into put-vector-text
seisman 17098a7
Merge branch 'master' into put-vector-text
seisman f1ce983
Merge branch 'master' into put-vector-text
weiji14 cadfec0
Fix a broken test
seisman e9a44ab
Merge branch 'master' into put-vector-text
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea of the test is to pass different combinations of strings to GMT, let GMT write it to a temporary file, and check if the output is the same as expected (i.e., if
vector=expected_vetcor.Still has trouble testing datetime strings, when the text file contains strings,
doesn't works as I expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in bf7587c, but could still be improved.