Skip to content

Auth suport action code settings.link domain #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Auth suport action code settings.link domain #741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ebb829
bump Firebase Cocoapods from 11.4.0 to 11.8.0
treitter Jun 24, 2025
2619870
bump Firebase BOM from 33.10.0 to 33.15.0
treitter Jun 24, 2025
ef183fc
auth: support ActionCodeSettings.linkDomain property
treitter Jun 24, 2025
febcdc8
Merge remote-tracking branch 'treit/issue-731-linkDomain' into auth-s…
Reedyuk Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions firebase-auth/src/androidMain/kotlin/dev/gitlive/firebase/auth/auth.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ internal fun ActionCodeSettings.toAndroid() = com.google.firebase.auth.ActionCod
.setUrl(url)
.also { androidPackageName?.run { it.setAndroidPackageName(packageName, installIfNotAvailable, minimumVersion) } }
.also { dynamicLinkDomain?.run { it.setDynamicLinkDomain(this) } }
.also { linkDomain?.run { it.setLinkDomain(this) } }
.setHandleCodeInApp(canHandleCodeInApp)
.also { iOSBundleId?.run { it.setIOSBundleId(this) } }
.build()
Expand Down
1 change: 1 addition & 0 deletions firebase-auth/src/commonMain/kotlin/dev/gitlive/firebase/auth/auth.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public data class ActionCodeSettings(
val dynamicLinkDomain: String? = null,
val canHandleCodeInApp: Boolean = false,
val iOSBundleId: String? = null,
val linkDomain: String? = null,
)

public data class AndroidPackageName(
Expand Down
1 change: 1 addition & 0 deletions firebase-auth/src/iosMain/kotlin/dev/gitlive/firebase/auth/auth.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ internal fun ActionCodeSettings.toIos() = FIRActionCodeSettings().also {
it.setURL(NSURL.URLWithString(url))
androidPackageName?.run { it.setAndroidPackageName(packageName, installIfNotAvailable, minimumVersion) }
it.setDynamicLinkDomain(dynamicLinkDomain)
it.setLinkDomain(linkDomain)
it.setHandleCodeInApp(canHandleCodeInApp)
iOSBundleId?.run { it.setIOSBundleID(this) }
}
Expand Down
1 change: 1 addition & 0 deletions firebase-auth/src/jsMain/kotlin/dev/gitlive/firebase/auth/auth.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ public actual class AuthTokenResult(internal val js: IdTokenResult) {
internal fun ActionCodeSettings.toJson() = json(
"url" to url,
"android" to (androidPackageName?.run { json("installApp" to installIfNotAvailable, "minimumVersion" to minimumVersion, "packageName" to packageName) } ?: undefined),
"linkDomain" to (linkDomain ?: undefined),
"dynamicLinkDomain" to (dynamicLinkDomain ?: undefined),
"handleCodeInApp" to canHandleCodeInApp,
"ios" to (iOSBundleId?.run { json("bundleId" to iOSBundleId) } ?: undefined),
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ androidx-test-core = "1.7.0"
androidx-test-junit = "1.3.0"
androidx-test-runner = "1.7.0"
ben-manes-versions = "0.52.0"
firebase-bom = "33.10.0"
firebase-bom = "33.15.0"
gitlive-firebase-java-sdk = "0.4.6"
gson = "2.13.1"
junit = "4.13.2"
Expand Down
Loading