修复 macOS 下剩余内存读取问题 #4876
Open
修复 macOS 下剩余内存读取问题 #4876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavo
reviewed
Nov 30, 2025
| long freePages = -1; | ||
| long inactivePages = -1; | ||
|
|
||
| try (var reader = process.inputReader()) { |
Member
There was a problem hiding this comment.
不要这样用 inputReader，应该显式指定编码为 OperatingSystem.NATIVE_CHARSET。
|
|
||
| try (var reader = process.inputReader()) { | ||
| String line; | ||
| while ((line = reader.readLine()) != null) { |
Member
There was a problem hiding this comment.
为什么要在这里重复实现一遍列表解析，而不用 KeyValuePairUtils.loadList？
Contributor
Author
There was a problem hiding this comment.
应该用KeyValuePairUtils.loadPair更为合适，我将进行调整
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3980
实现逻辑：通过
vm_stat命令获取空闲内存，内存读取较原有逻辑误差显著降低受限于手头设备原因，这可能需要额外的测试来证明代码可用性
Before
After
误差原因：这是同时计算了
vm_stat输出的Pages inactive和Pages free，可能逻辑与检测工具之间存在差异