Feature/validation in configterms #272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferag
requested changes
Dec 3, 2025
| "Homogenizing format and type of the metadata value for the given (raw) metadata: %s" | ||
| % term_values | ||
| ) | ||
| term_values_list = plugin.metadata_utils.gather( |
Collaborator
There was a problem hiding this comment.
I have problems with this metadata_utils. Is it something that should implement each plugin?
Collaborator
Author
There was a problem hiding this comment.
yes unfortunately:
- Write a class where you will add the
_get_*and_validate_*methods (e.g. epos plugin) - Define a property
metadata_utilsthat instantiates the class above:
@property
def metadata_utils(self):
return MetadataValues()Of course this implementation could be improved to remove these requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.