Skip to content

Revert toggle directive to use afterNextRender and update tests to wait for rendering #16430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Revert toggle directive to use afterNextRender and update tests to wait for rendering #16430

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e655786
Initial plan
Copilot Nov 7, 2025
8bbe7d5
fix: replace afterNextRender with setTimeout and add tick() to tests
Copilot Nov 7, 2025
e97d156
fix: use double detectChanges to ensure host bindings update
Copilot Nov 7, 2025
049fa50
Fix toggle directive with requestAnimationFrame and update tests with…
Copilot Nov 7, 2025
c67732f
Revert to afterNextRender and convert toggle tests to async/await
Copilot Nov 10, 2025
c1fde5a
Revert toggle directive to use afterNextRender and update tests to wa…
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions projects/igniteui-angular/src/lib/directives/toggle/toggle.directive.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,29 +61,30 @@ describe('IgxToggle', () => {
expect(divEl.classList.contains(TOGGLER_CLASS)).toBeTruthy();
});

it('should emit \'opening\' and \'opened\' events', fakeAsync(() => {
it('should emit \'opening\' and \'opened\' events', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

const toggle = fixture.componentInstance.toggle;
spyOn(toggle.opening, 'emit');
spyOn(toggle.opened, 'emit');
toggle.open();
tick();
await fixture.whenStable();
await fixture.whenRenderingDone();
fixture.detectChanges();

expect(toggle.opening.emit).toHaveBeenCalled();
expect(toggle.opened.emit).toHaveBeenCalled();
}));
});

it('should emit \'appended\' event', fakeAsync(() => {
it('should emit \'appended\' event', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

const toggle = fixture.componentInstance.toggle;
spyOn(toggle.appended, 'emit');
toggle.open();
tick();
await fixture.whenRenderingDone();
fixture.detectChanges();

expect(toggle.appended.emit).toHaveBeenCalledTimes(1);
Expand All @@ -96,15 +97,15 @@ describe('IgxToggle', () => {
fixture.detectChanges();

expect(toggle.appended.emit).toHaveBeenCalledTimes(2);
}));
});

it('should emit \'onClosing\' and \'closed\' events', fakeAsync(() => {
it('should emit \'onClosing\' and \'closed\' events', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

const toggle = fixture.componentInstance.toggle;
fixture.componentInstance.toggle.open();
tick();
await fixture.whenRenderingDone();
fixture.detectChanges();

spyOn(toggle.closing, 'emit');
Expand All @@ -115,9 +116,9 @@ describe('IgxToggle', () => {

expect(toggle.closing.emit).toHaveBeenCalledTimes(1);
expect(toggle.closed.emit).toHaveBeenCalledTimes(1);
}));
});

it('should propagate IgxOverlay opened/closed events', fakeAsync(() => {
it('should propagate IgxOverlay opened/closed events', async () => {
const fixture = TestBed.createComponent(IgxOverlayServiceComponent);
fixture.detectChanges();

Expand All @@ -127,7 +128,7 @@ describe('IgxToggle', () => {
spyOn(toggle.closed, 'emit');

toggle.open();
tick();
await fixture.whenRenderingDone();
expect(toggle.opened.emit).toHaveBeenCalledTimes(1);
expect(toggle.collapsed).toBe(false);
toggle.close();
Expand All @@ -148,7 +149,7 @@ describe('IgxToggle', () => {
tick();
expect(toggle.closed.emit).toHaveBeenCalledTimes(2);
expect(toggle.collapsed).toBe(true);
}));
});

it('should open toggle when IgxToggleActionDirective is clicked and toggle is closed', fakeAsync(() => {
const fixture = TestBed.createComponent(IgxToggleActionTestComponent);
Expand All @@ -166,11 +167,11 @@ describe('IgxToggle', () => {
expect(divEl.classes[TOGGLER_CLASS]).toBe(true);
}));

it('should close toggle when IgxToggleActionDirective is clicked and toggle is opened', fakeAsync(() => {
it('should close toggle when IgxToggleActionDirective is clicked and toggle is opened', async () => {
const fixture = TestBed.createComponent(IgxToggleActionTestComponent);
fixture.detectChanges();
fixture.componentInstance.toggle.open();
tick();
await fixture.whenRenderingDone();

const divEl = fixture.debugElement.query(By.directive(IgxToggleDirective)).nativeElement;
const button: DebugElement = fixture.debugElement.query(By.directive(IgxToggleActionDirective));
Expand All @@ -182,7 +183,7 @@ describe('IgxToggle', () => {
tick();
fixture.detectChanges();
expect(divEl.classList.contains(HIDDEN_TOGGLER_CLASS)).toBeTruthy();
}));
});

it('should hide content and emit \'closed\' event when you click outside the toggle\'s content', fakeAsync(() => {
const fixture = TestBed.createComponent(IgxToggleActionTestComponent);
Expand Down Expand Up @@ -277,7 +278,7 @@ describe('IgxToggle', () => {
expect(toggleElm.classList.contains(HIDDEN_TOGGLER_CLASS)).toBe(true);
}));

it('fix for #2798 - Allow canceling of open and close of IgxDropDown through opening and closing events', fakeAsync(() => {
it('fix for #2798 - Allow canceling of open and close of IgxDropDown through opening and closing events', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

Expand All @@ -293,7 +294,7 @@ describe('IgxToggle', () => {

toggle.open();
fixture.detectChanges();
tick();
await fixture.whenRenderingDone();

expect(toggle.opening.emit).toHaveBeenCalledTimes(1);
expect(toggle.opened.emit).toHaveBeenCalledTimes(1);
Expand All @@ -320,7 +321,7 @@ describe('IgxToggle', () => {

expect(toggle.opening.emit).toHaveBeenCalledTimes(2);
expect(toggle.opened.emit).toHaveBeenCalledTimes(1);
}));
});

it('fix for #3636 - ToggleAction should provide its element as target', fakeAsync(() => {
const fixture = TestBed.createComponent(TestWithThreeToggleActionsComponent);
Expand Down Expand Up @@ -421,15 +422,15 @@ describe('IgxToggle', () => {
expect(Math.round(toggleRect.top)).toBe(Math.round(buttonRect.bottom));
}));

it('fix for #3810 - Should not open toggle when already opened', fakeAsync(() => {
it('fix for #3810 - Should not open toggle when already opened', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

const toggle = fixture.componentInstance.toggle;
spyOn(toggle.opening, 'emit');
spyOn(toggle.opened, 'emit');
toggle.open();
tick();
await fixture.whenRenderingDone();
fixture.detectChanges();

expect(toggle.opening.emit).toHaveBeenCalledTimes(1);
Expand All @@ -441,17 +442,17 @@ describe('IgxToggle', () => {

expect(toggle.opening.emit).toHaveBeenCalledTimes(1);
expect(toggle.opened.emit).toHaveBeenCalledTimes(1);
}));
});

it('fix for #3810 - Should not close toggle when not open', fakeAsync(() => {
it('fix for #3810 - Should not close toggle when not open', async () => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
fixture.detectChanges();

const toggle = fixture.componentInstance.toggle;
spyOn(toggle.opening, 'emit');
spyOn(toggle.opened, 'emit');
toggle.open();
tick();
await fixture.whenRenderingDone();
fixture.detectChanges();

expect(toggle.opening.emit).toHaveBeenCalledTimes(1);
Expand All @@ -472,7 +473,7 @@ describe('IgxToggle', () => {

expect(toggle.closing.emit).toHaveBeenCalledTimes(1);
expect(toggle.closed.emit).toHaveBeenCalledTimes(1);
}));
});

it('fix for #4222 - Should emit closed when closed second time', fakeAsync(() => {
const fixture = TestBed.createComponent(IgxToggleTestComponent);
Expand Down