Skip to content

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Apr 9, 2025

In this PR,

  1. GitHub work flow for build pip is update to avoid a warning.
Click to see the warning Warning: The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.
  1. Build step in GitHub work flow for build pip is updated to use optional-dependencies to install packages needed for test.

  2. Python 3.11 and 3.12 are added to matrix test of conda package.

@vtavana vtavana self-assigned this Apr 9, 2025
@vtavana vtavana marked this pull request as ready for review April 9, 2025 05:32
ndgrigorian
ndgrigorian previously approved these changes Apr 9, 2025
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Anton <100830759+antonwolfy@users.noreply.github.com>
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana, no more comments from me

@vtavana vtavana merged commit 58c8469 into master Apr 9, 2025
49 checks passed
@vtavana vtavana deleted the update-work-flow branch April 9, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants