update recipe to use numpy-base
#209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtavana
requested review from
antonwolfy,
ekomarova,
ndgrigorian and
xaleryb
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the conda recipe to use numpy-base instead of numpy for dependency management. This change establishes a cleaner dependency hierarchy where MKL packages depend on numpy-base and numpy depends on both MKL packages and numpy-base.
- Replace
numpywithnumpy-basein the recipe's runtime dependencies - Modify CI workflows to handle scipy installation conditionally for Python 3.9 due to dependency conflicts
- Remove Python 3.9-specific MKL-devel version constraint
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| conda-recipe/meta.yaml | Updates runtime dependency from numpy to numpy-base and removes Python 3.9 build constraint |
| .github/workflows/conda-package.yml | Modifies test workflows to install scipy conditionally to avoid dependency conflicts with Python 3.9 |
ekomarova
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help to have the following dependency
mkl_* -> numpy-baseand thennumpy -> mkl_*, numpy-base.