-
Notifications
You must be signed in to change notification settings - Fork 53
Update for more recent Julia versions #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8c7a3cb
Update for more recent Julia versions
rdeits 6ece0dd
Fix disallowed characters in doc `@setup`
rdeits c817d37
skip test on older Julia versions
rdeits d21e6a3
fix bad regex
rdeits 2199c04
Restrict Rotations.jl to < 1.3
rdeits a11ee52
Updates the names used to access fields of `QuatRotation`
ferrolho 792ef69
Get underlying quaternion parameters via `Rotations.params(q)`
ferrolho 7059f0e
work around `replace` issue in docs build
rdeits 9707d02
Update example manifests for Rotations.jl 1.2
rdeits ad72524
try to fix SymPy import
rdeits 8ba0b3a
regenerate manifests again for julia 1.9
rdeits e339a4f
skip notebook tests on versions < 1.9
rdeits 2498b9e
widen MeshCat compatibility to fix issue with Adapt.jl
rdeits 19e7f62
also skip benchmarks with incompatible manifest
rdeits 839257f
skip symbolics notebook until it becomes compatible with quaternions
ferrolho 691511a
Merge pull request #635 from ferrolho/rd/update-ci
rdeits 7441381
Update manifests again and fix broken deprecated function
rdeits 3ae30f4
Update manifests for MeshCat 0.16.0
rdeits 21bf8bf
bump version to 2.5.0
rdeits 7702c50
stop using pyplot in favour of the default (GR) in notebook 4
ferrolho d484b0d
Merge pull request #636 from ferrolho/hf/revert-pyplot
rdeits 34dbcbb
fix version
rdeits File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could increment it to 2.4.0 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge from my end (I don't have permissions to do it).