Skip to content

fix: ignore spring animation on mount when currentIndex !== 0 #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: ignore spring animation on mount when currentIndex !== 0 #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 10 additions & 9 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ const SegmentedControl: React.FC<SegmentedControlProps> = ({
}: SegmentedControlProps) => {
const width = widthPercentageToDP('100%') - containerMargin * 2;
const translateValue = width / segments.length;
const tabTranslateValue = useSharedValue(0);
const tabTranslateValue = useSharedValue(currentIndex);
// If phone is set to RTL, make sure the animation does the correct transition.
const transitionMultiplier = isRTL ? -1 : 1;

// useCallBack with an empty array as input, which will call inner lambda only once and memoize the reference for future calls
const memoizedTabPressCallback = React.useCallback(
Expand All @@ -123,20 +125,19 @@ const SegmentedControl: React.FC<SegmentedControlProps> = ({
[onChange]
);
useEffect(() => {
// If phone is set to RTL, make sure the animation does the correct transition.
const transitionMultiplier = isRTL ? -1 : 1;
tabTranslateValue.value = withSpring(
currentIndex * (translateValue * transitionMultiplier),
DEFAULT_SPRING_CONFIG
);
tabTranslateValue.value = currentIndex;
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [currentIndex]);

const tabTranslateAnimatedStyles = useAnimatedStyle(() => {
const translateX = withSpring(
tabTranslateValue.value * (translateValue * transitionMultiplier),
DEFAULT_SPRING_CONFIG
);
return {
transform: [{ translateX: tabTranslateValue.value }],
transform: [{ translateX }],
};
});
}, [translateValue, transitionMultiplier]);

const finalisedActiveTextStyle: TextStyle = {
fontSize: 15,
Expand Down