Feat: Implement ES256K support for secp256k1 signed JWTs #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
force-pushed
the
feat/implement-secp256k1-ES256K
branch
from
4c71cca to
bcb6d41
Compare
Keats
requested changes
Nov 18, 2025
Owner
Keats
left a comment
Keats
left a comment
There was a problem hiding this comment.
I think we shouldn't expose it when using the aws-ls-crypto feature since we can't actually use it there
| ES384, | ||
|
|
||
| /// ECDSA using secp256k1 | ||
| ES256K, |
Owner
There was a problem hiding this comment.
should this be gated by rust_crypto feature since it's only available there? As well as all JWK operations?
Author
There was a problem hiding this comment.
I'm not sure how to make this rust_crypto gated (that's a little beyond my current knowledge of rust)
would it be something like wrapping in: };
#[cfg(feature = "rust_crypto")]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #391, and I've tested it for compatibility with the JWTs that the AT Protocol codebase produces (it's a little complex on the node.js/javascript side, so I haven't included that but I can if need be).
The error I mentioned in that ticket was because I was accidentally doing
Validation::new(Algorithm::ES256),instead of&Validation::new(Algorithm::ES256K),when decoding the JWT, which, super silly mistake, but I caught it today!This would unblock: mike-engel/jwt-cli#402