fix(IFCImporter): optimize IFC parsing #3368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finetjul
approved these changes
Nov 24, 2025
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Does it really change performance ?
Collaborator
Author
|
Not exactly, i just changed it to avoid declaring an array inside the loop(as you stated many time 😄) |
finetjul
reviewed
Dec 2, 2025
daker
force-pushed
the
optimize-ifcimporter
branch
from
bfdfe42 to
439a826
Compare
daker
force-pushed
the
optimize-ifcimporter
branch
from
439a826 to
76d8542
Compare
finetjul
reviewed
Dec 3, 2025
daker
force-pushed
the
optimize-ifcimporter
branch
from
76d8542 to
4ab52c0
Compare
|
🎉 This PR is included in version 34.15.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting