Skip to content

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Oct 19, 2025

What does this PR do?

Fixes #10636

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21297.org.readthedocs.build/en/21297/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 19, 2025
Copy link
Collaborator

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to block until we have agreed on a interface in #10636

@SkafteNicki SkafteNicki added the logger Related to the Loggers label Oct 20, 2025
@GdoongMathew GdoongMathew changed the title Feat/logger_map [WIP]Feat/logger_map Oct 20, 2025
@GdoongMathew GdoongMathew changed the title [WIP]Feat/logger_map [WIP] Feat/logger_map Oct 20, 2025
@GdoongMathew GdoongMathew marked this pull request as draft October 20, 2025 10:08
@GdoongMathew GdoongMathew marked this pull request as ready for review October 22, 2025 16:18
@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 89.26174% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 79%. Comparing base (32442c2) to head (3211f15).
⚠️ Report is 20 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21297    +/-   ##
========================================
- Coverage      80%      79%    -1%     
========================================
  Files         270      267     -3     
  Lines       23799    23885    +86     
========================================
- Hits        19075    18824   -251     
- Misses       4724     5061   +337     

@bhimrazy bhimrazy marked this pull request as draft November 5, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

logger Related to the Loggers pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Trainer] dictionary access to multiple named loggers

2 participants