Skip to content

Uses Deface instead of overriding core view #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.0.x
Choose a base branch
from
Open

Uses Deface instead of overriding core view #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324d694
Uses deface instead of overriding core view
Feb 19, 2025
28ca5ad
Added incorrectly removed files
Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
gem 'haml-rails'
gem 'deface'
1 change: 1 addition & 0 deletions app/overrides/issues/index/0-remove_view_issues_index_header_hook.html.erb.deface
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- remove 'erb[loud]:contains("view_issues_index_header")' -->
2 changes: 2 additions & 0 deletions app/overrides/issues/index/1-add_view_issues_index_header_hook.html.erb.deface
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<!-- insert_before '.contextual' -->
<%= call_hook(:view_issues_index_header, {issues: @issues, project: @project, query: @query}) %>
1 change: 1 addition & 0 deletions app/overrides/issues/index/2-remove_view_issues_index_contextual_hook.html.erb.deface
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<!-- remove 'erb[loud]:contains("view_issues_index_contextual")' -->
2 changes: 2 additions & 0 deletions app/overrides/issues/index/3-add_view_issues_index_contextual_hook.html.erb.deface
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
<!-- insert_bottom '.contextual' -->
<%= call_hook(:view_issues_index_contextual, {issues: @issues, project: @project, query: @query}) %>
100 changes: 0 additions & 100 deletions app/views/issues/index.html.erb
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions init.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@
push('issues_trees/tree_index').
push('issues_trees/redirect_with_params').
push('issues_trees/tree_children')

# Add deface overrides files path.
Rails.application.paths["app/overrides"] ||= []
Rails.application.paths["app/overrides"] << File.expand_path("../app/overrides", __FILE__)