Skip to content

Conversation

@naji247
Copy link
Member

@naji247 naji247 commented Nov 19, 2025

Summary

This PR reverts the actor correlation changes that were implemented for session identification. The changes were causing complexity and potential issues with session management.

Changes

  • Removes actor correlation logic from session identification
  • Simplifies session management back to the original implementation
  • Removes related test files (identify.test.ts and session-id.test.ts)
  • Cleans up internal module dependencies

Motivation

The actor correlation approach added significant complexity without providing sufficient value for the current use case. Reverting to the simpler session management approach improves maintainability and reduces potential edge cases.

Impact

  • Breaking Change: No
  • Files Changed: 5 files
  • Lines Removed: ~1048 lines (mostly test code)
  • Lines Added: ~9 lines

Testing

The simplified session management has been tested and maintains backward compatibility with existing implementations.

@naji247 naji247 requested a review from kashishhora November 19, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants