Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 63 additions & 3 deletions src/modules/exceptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,23 @@ const MAX_STACK_FRAMES = 50;
* detects whether each frame is user code (in_app: true) or library code (in_app: false).
*
* @param error - The error to capture (can be Error, string, object, or any value)
* @param contextStack - Optional Error object to use for stack context (for validation errors)
* @returns ErrorData object with structured error information
*/
export function captureException(error: unknown): ErrorData {
export function captureException(
error: unknown,
contextStack?: Error,
): ErrorData {
// Handle CallToolResult objects (SDK 1.21.0+ converts errors to these)
if (isCallToolResult(error)) {
return captureCallToolResultError(error, contextStack);
}

// Handle non-Error objects
if (!(error instanceof Error)) {
return {
message: stringifyNonError(error),
type: "NonError",
type: "UnknownErrorType",
platform: "javascript",
};
Comment on lines 31 to 36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think based on their code, we know it is an McpError type I'm pretty sure. You could do a quick includes check or something here.

}
Expand Down Expand Up @@ -677,7 +686,7 @@ function unwrapErrorCauses(error: Error): ChainedErrorData[] {
if (!(currentError instanceof Error)) {
chainedErrors.push({
message: stringifyNonError(currentError),
type: "NonError",
type: "UnknownErrorType",
});
break;
}
Expand Down Expand Up @@ -708,6 +717,57 @@ function unwrapErrorCauses(error: Error): ChainedErrorData[] {
return chainedErrors;
}

/**
* Detects if a value is a CallToolResult object (SDK 1.21.0+ error format).
*
* SDK 1.21.0+ converts errors to CallToolResult format:
* { content: [{ type: "text", text: "error message" }], isError: true }
*
* @param value - Value to check
* @returns True if value is a CallToolResult object
*/
function isCallToolResult(value: unknown): boolean {
return (
value !== null &&
typeof value === "object" &&
"isError" in value &&
"content" in value &&
Array.isArray((value as any).content)
);
}

/**
* Extracts error information from CallToolResult objects.
*
* SDK 1.21.0+ converts errors to CallToolResult, losing original stack traces.
* This extracts the error message from the content array.
*
* @param result - CallToolResult object with error
* @param _contextStack - Optional Error object for stack context (unused, kept for compatibility)
* @returns ErrorData with extracted message (no stack trace)
*/
function captureCallToolResultError(
result: any,
_contextStack?: Error,
): ErrorData {
// Extract message from content array
const message =
result.content
?.filter((c: any) => c.type === "text")
.map((c: any) => c.text)
.join(" ")
.trim() || "Unknown error";

const errorData: ErrorData = {
message,
type: "UnknownErrorType", // Can't determine actual type from CallToolResult
platform: "javascript",
// No stack or frames - SDK stripped the original error information
};

return errorData;
}

/**
* Converts non-Error objects to string representation for error messages.
*
Expand Down
Loading