Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/services.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,7 @@ services:
- { name: kernel.event_subscriber }

Macpaw\SchemaContextBundle\Messenger\Middleware\BaggageSchemaMiddleware:
arguments:
$sendersLocator: '@messenger.senders_locator'
tags:
- { name: messenger.middleware }
21 changes: 20 additions & 1 deletion src/Messenger/Middleware/BaggageSchemaMiddleware.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,13 @@
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
use Symfony\Component\Messenger\Middleware\StackInterface;
use Symfony\Component\Messenger\Stamp\ReceivedStamp;
use Symfony\Component\Messenger\Transport\Sender\SendersLocatorInterface;
use Symfony\Component\Messenger\Transport\Sync\SyncTransport;

class BaggageSchemaMiddleware implements MiddlewareInterface
{
public function __construct(
private SendersLocatorInterface $sendersLocator,
private BaggageSchemaResolver $baggageSchemaResolver,
private BaggageCodec $baggageCodec,
) {
Expand All @@ -24,7 +27,7 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope
{
$stamp = $envelope->last(BaggageSchemaStamp::class);

if ($envelope->last(ReceivedStamp::class)) {
if ($this->isWorker($envelope) && !$this->isSyncTransport($envelope)) {
if ($stamp instanceof BaggageSchemaStamp) {
$this->baggageSchemaResolver
->setSchema($stamp->schema)
Expand All @@ -47,4 +50,20 @@ public function handle(Envelope $envelope, StackInterface $stack): Envelope

return $stack->next()->handle($envelope, $stack);
}

private function isWorker(Envelope $envelope): bool
{
return (bool) $envelope->last(ReceivedStamp::class);
}

private function isSyncTransport(Envelope $envelope): bool
{
foreach ($this->sendersLocator->getSenders($envelope) as $sender) {
if ($sender instanceof SyncTransport) {
return true;
}
}

return false;
}
}
11 changes: 8 additions & 3 deletions tests/Messenger/Middleware/BaggageSchemaMiddlewareTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Symfony\Component\Messenger\Middleware\MiddlewareInterface;
use Symfony\Component\Messenger\Middleware\StackInterface;
use Symfony\Component\Messenger\Stamp\ReceivedStamp;
use Symfony\Component\Messenger\Transport\Sender\SendersLocatorInterface;

class BaggageSchemaMiddlewareTest extends TestCase
{
Expand All @@ -28,9 +29,10 @@ public function testSchemaIsSetFromStamp(): void
'X-Schema' => 'tenant1',
];

$sendersLocator = $this->createMock(SendersLocatorInterface::class);
$resolver = new BaggageSchemaResolver($environmentSchema, $environmentName, $schemaOverridableEnvironments);
$baggageCodec = new BaggageCodec();
$middleware = new BaggageSchemaMiddleware($resolver, $baggageCodec);
$middleware = new BaggageSchemaMiddleware($sendersLocator, $resolver, $baggageCodec);
$stamp = new BaggageSchemaStamp($schema, $rawBaggage);
$envelope = (new Envelope(new \stdClass()))->with($stamp);
$envelope = $envelope->with(new ReceivedStamp('async'));
Expand Down Expand Up @@ -73,12 +75,14 @@ public function testSchemaStampIsInjectedIfMissing(): void
$baggage = [
'X-Schema' => 'tenant1',
];

$sendersLocator = $this->createMock(SendersLocatorInterface::class);
$resolver = new BaggageSchemaResolver($environmentSchema, $environmentName, $schemaOverridableEnvironments);
$resolver
->setSchema($schema)
->setBaggage($baggage);
$baggageCodec = new BaggageCodec();
$middleware = new BaggageSchemaMiddleware($resolver, $baggageCodec);
$middleware = new BaggageSchemaMiddleware($sendersLocator, $resolver, $baggageCodec);
$originalEnvelope = new Envelope(new \stdClass());
$stack = $this->createMock(StackInterface::class);

Expand Down Expand Up @@ -108,9 +112,10 @@ public function testSchemaStampIsDefaultSchema(): void
$environmentName = 'dev';
$schemaOverridableEnvironments = ['dev', 'test'];

$sendersLocator = $this->createMock(SendersLocatorInterface::class);
$resolver = new BaggageSchemaResolver($environmentSchema, $environmentName, $schemaOverridableEnvironments);
$baggageCodec = new BaggageCodec();
$middleware = new BaggageSchemaMiddleware($resolver, $baggageCodec);
$middleware = new BaggageSchemaMiddleware($sendersLocator, $resolver, $baggageCodec);
$originalEnvelope = new Envelope(new \stdClass());
$stack = $this->createMock(StackInterface::class);

Expand Down
Loading