Merge pull request #151 from MihaiCristianCondrea/codex/design-professional-onboarding-experience

Refine onboarding flow with data consent and completion screens

Author: MihaiCristianCondrea

app/build.gradle

@@ -42,6 +42,7 @@ android {
 
     buildFeatures {
         viewBinding true
+        dataBinding true
         buildConfig true
     }
 

app/src/main/java/com/d4rk/androidtutorials/java/ads/views/NativeAdBannerView.java

@@ -39,7 +39,7 @@ public NativeAdBannerView(@NonNull Context context, @Nullable AttributeSet attrs
 
     private void init(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr) {
         if (attrs != null) {
-            TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0);
+            TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0); // FIXME: 'TypedArray' used without 'try'-with-resources statement
             layoutRes = a.getResourceId(R.styleable.NativeAdBannerView_nativeAdLayout, R.layout.ad_home_banner_large);
             a.recycle();
         }
@@ -49,7 +49,7 @@ public void loadAd(AdRequest adRequest) {
         loadAd(adRequest, null);
     }
 
-    public void loadAd(AdRequest adRequest, @Nullable AdListener listener) {
+    public void loadAd(AdRequest adRequest, @Nullable AdListener listener) { // FIXME: Parameter 'adRequest' is never used
         NativeAdLoader.load(getContext(), this, layoutRes, listener);
     }
 

app/src/main/java/com/d4rk/androidtutorials/java/data/repository/DefaultHomeRepository.java

@@ -28,7 +28,7 @@ public String getAppPlayStoreUrl(String packageName) {
     }
 
     @Override
-    public String getDailyTip() {
+    public String dailyTip() {
         return localDataSource.getDailyTip();
     }
 

app/src/main/java/com/d4rk/androidtutorials/java/data/repository/HomeRepository.java

@@ -13,7 +13,7 @@ public interface HomeRepository {
 
     String getAppPlayStoreUrl(String packageName);
 
-    String getDailyTip();
+    String dailyTip();
 
     void fetchPromotedApps(PromotedAppsCallback callback);
 

app/src/main/java/com/d4rk/androidtutorials/java/domain/home/GetDailyTipUseCase.java

@@ -16,6 +16,6 @@ public GetDailyTipUseCase(HomeRepository repository) {
      * Returns today's tip string.
      */
     public String invoke() {
-        return repository.getDailyTip();
+        return repository.dailyTip();
     }
 }

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/about/AboutFragment.java

@@ -67,7 +67,7 @@ public android.view.View onCreateView(@NonNull android.view.LayoutInflater infla
         });
 
         binding.imageViewAppIcon.setOnClickListener(
-                v -> openUrl("https://d4rk7355608.github.io/home/"));
+                v -> openUrl("https://mihaicristiancondrea.github.io/profile"));
         binding.chipGoogleDev.setOnClickListener(
                 v -> openUrl("https://g.dev/D4rK7355608"));
         binding.chipYoutube.setOnClickListener(

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/data/room/RoomActivity.java

@@ -89,7 +89,7 @@ protected void onDestroy() {
 
     private static class NotesAdapter extends ListAdapter<Note, NotesAdapter.NoteViewHolder> {
         private static final DiffUtil.ItemCallback<Note> DIFF_CALLBACK =
-                new DiffUtil.ItemCallback<Note>() {
+                new DiffUtil.ItemCallback<>() {
                     @Override
                     public boolean areItemsTheSame(@NonNull Note oldItem, @NonNull Note newItem) {
                         return oldItem.id == newItem.id;

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/networking/retrofit/RetrofitActivity.java

@@ -44,9 +44,9 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
 
         binding.buttonFetch.setOnClickListener(v -> {
             binding.buttonFetch.setEnabled(false);
-            api.getTodo().enqueue(new Callback<Todo>() {
+            api.getTodo().enqueue(new Callback<>() {
                 @Override
-                public void onResponse(Call<Todo> call, Response<Todo> response) {
+                public void onResponse(Call<Todo> call, Response<Todo> response) { // FIXME: Not annotated parameter overrides @EverythingIsNonNull parameter
                     if (response.isSuccessful() && response.body() != null) {
                         binding.textViewResult.setText(response.body().title);
                     } else {
@@ -56,7 +56,7 @@ public void onResponse(Call<Todo> call, Response<Todo> response) {
                 }
 
                 @Override
-                public void onFailure(Call<Todo> call, Throwable t) {
+                public void onFailure(Call<Todo> call, Throwable t) { // FIXME: Not annotated parameter overrides @EverythingIsNonNull parameter
                     binding.textViewResult.setText(R.string.snack_general_error);
                     binding.buttonFetch.setEnabled(true);
                 }

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/start/AndroidStartProjectActivity.java

@@ -25,7 +25,7 @@ protected void onCreate(Bundle savedInstanceState) {
         edgeToEdgeDelegate.applyEdgeToEdge(binding.constraintLayout);
 
         setSupportActionBar(binding.topAppBar);
-        binding.topAppBar.setNavigationOnClickListener(v -> onBackPressed());
+        binding.topAppBar.setNavigationOnClickListener(v -> onBackPressed()); // FIXME: 'onBackPressed()' is deprecated
         binding.topAppBar.setOnMenuItemClickListener(item -> {
             if (item.getItemId() == R.id.action_share) {
                 Intent sharingIntent = new Intent(Intent.ACTION_SEND);

app/src/main/java/com/d4rk/androidtutorials/java/ui/screens/android/lessons/textboxes/passwordbox/PasswordBoxActivity.java

@@ -62,7 +62,7 @@ private void hidePassword() {
 
     private void addKeyListener() {
         binding.buttonShowPassword.setOnClickListener(v ->
-                Snackbar.make(binding.getRoot(), binding.editText.getText(), Snackbar.LENGTH_LONG).show());
+                Snackbar.make(binding.getRoot(), binding.editText.getText(), Snackbar.LENGTH_LONG).show()); // FIXME: Argument 'binding.editText.getText()' might be null
     }