Skip to content

Conversation

@MihaiCristianCondrea
Copy link
Owner

Summary

  • Add custom layout for Android Studio settings with preference list and bottom native ad banner.
  • Update bottom app bar ad layout to use MaterialCardView and required attribution snippet.
  • Inflate new layout in AndroidStudioFragment and load native ads on view creation.

Testing

  • ./gradlew test (fails: SDK location not found)

https://chatgpt.com/codex/tasks/task_e_68c248bb43c8832d85a119a60050c11a

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +36 to +39
@Override
public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup container,
@Nullable Bundle savedInstanceState) {
return inflater.inflate(R.layout.fragment_android_studio, container, false);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Inflate custom layout without calling super

Overriding onCreateView now inflates fragment_android_studio directly and returns it without delegating to PreferenceFragmentCompat. The base implementation is responsible for creating and configuring the internal RecyclerView (layout manager, adapter, scroll listeners). Returning a raw layout means the preference list is never initialized, so the Android Studio settings screen will render empty and search filtering will have no list to operate on. The method should call super.onCreateView(...) and add the ad view to that hierarchy rather than replacing it.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants