Integrate native ad into Android Studio lessons #141
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| android:targetPackage="com.d4rk.androidtutorials.java" /> | ||
| </androidx.preference.Preference> | ||
| </androidx.preference.PreferenceCategory> | ||
| <com.d4rk.androidtutorials.java.ads.preferences.NativeAdPreference/> |
There was a problem hiding this comment.
[P1] Add title or null-check for native ad preference
The newly inserted NativeAdPreference has no title attribute. AndroidStudioFragment.applyFilter assumes every Preference returns a non-null title and calls pref.getTitle().toString() when the search view is used, which now throws a NullPointerException because this ad preference lacks a title. Either give this preference a dummy title or make the filter logic null-safe so searching in the Android Studio lessons screen doesn’t crash.
Useful? React with 👍 / 👎.
Summary
NativeAdPreferencethat loads ads viaNativeAdBannerViewTesting
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c24ab2bb64832d8e8bd877d661bbf3