Skip to content

Remove quiz feature and resolve FIXMEs #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2025
Merged

Remove quiz feature and resolve FIXMEs #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3defb6
Remove quiz feature and resolve FIXME issues
MihaiCristianCondrea Sep 12, 2025
f3c5036
Restore AdRequest overload for native ad views
MihaiCristianCondrea Sep 12, 2025
77cad2e
Persist onboarding defaults and neutral ad placeholder
MihaiCristianCondrea Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,16 +356,6 @@
android:exported="false"
android:label="@string/support_us"
android:parentActivityName=".ui.screens.support.SupportActivity" />
<activity
android:name=".ui.screens.quiz.QuizActivity"
android:exported="false"
android:label="@string/quiz_title"
android:parentActivityName=".ui.screens.quiz.QuizActivity" />

<receiver
android:name=".notifications.receivers.QuizReminderReceiver"
android:exported="false" />

<service
android:name="androidx.appcompat.app.AppLocalesMetadataHolderService"
android:enabled="false"
Expand Down
62 changes: 0 additions & 62 deletions app/src/main/assets/quiz_questions.json
View file
Open in desktop

This file was deleted.

15 changes: 7 additions & 8 deletions app/src/main/java/com/d4rk/androidtutorials/java/ads/views/NativeAdBannerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@
import com.d4rk.androidtutorials.java.R;
import com.d4rk.androidtutorials.java.ads.managers.NativeAdLoader;
import com.google.android.gms.ads.AdListener;
import com.google.android.gms.ads.AdRequest;

/**
* Custom view that acts as a drop-in replacement for AdView and loads
* a native ad using {@link NativeAdLoader} when {@link #loadAd(AdRequest)} is called.
* a native ad using {@link NativeAdLoader} when {@link #loadAd()} is called.
*/
public class NativeAdBannerView extends FrameLayout {

Expand All @@ -39,17 +38,17 @@ public NativeAdBannerView(@NonNull Context context, @Nullable AttributeSet attrs

private void init(@NonNull Context context, @Nullable AttributeSet attrs, int defStyleAttr) {
if (attrs != null) {
TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0); // FIXME: 'TypedArray' used without 'try'-with-resources statement
layoutRes = a.getResourceId(R.styleable.NativeAdBannerView_nativeAdLayout, R.layout.ad_home_banner_large);
a.recycle();
try (TypedArray a = context.obtainStyledAttributes(attrs, R.styleable.NativeAdBannerView, defStyleAttr, 0)) {
layoutRes = a.getResourceId(R.styleable.NativeAdBannerView_nativeAdLayout, R.layout.ad_home_banner_large);
}
}
}

public void loadAd(AdRequest adRequest) {
loadAd(adRequest, null);
public void loadAd() {
loadAd(null);
}

public void loadAd(AdRequest adRequest, @Nullable AdListener listener) { // FIXME: Parameter 'adRequest' is never used
public void loadAd(@Nullable AdListener listener) {
NativeAdLoader.load(getContext(), this, layoutRes, listener);
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] Update native ad call sites after signature change

The updated NativeAdBannerView drops the AdRequest parameter and now exposes loadAd()/loadAd(@Nullable AdListener) (lines 47‑52). SupportActivity and HomeFragment still invoke loadAd(request) when initializing their native banners (supportNativeAd.loadAd(adRequest) and smallBannerAd.loadAd(request)), so the project no longer compiles because those method overloads no longer exist. Call sites need to be updated to call the new parameterless API or pass an AdListener instead.

Useful? React with 👍 / 👎.

}

Expand Down
11 changes: 0 additions & 11 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/model/QuizQuestion.java
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/repository/DefaultQuizRepository.java
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/repository/QuizRepository.java
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/source/DefaultQuizLocalDataSource.java
View file
Open in desktop

This file was deleted.

17 changes: 0 additions & 17 deletions app/src/main/java/com/d4rk/androidtutorials/java/data/source/QuizLocalDataSource.java
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions app/src/main/java/com/d4rk/androidtutorials/java/di/AppModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,14 @@
import com.android.volley.toolbox.Volley;
import com.d4rk.androidtutorials.java.data.repository.DefaultHomeRepository;
import com.d4rk.androidtutorials.java.data.repository.DefaultMainRepository;
import com.d4rk.androidtutorials.java.data.repository.DefaultQuizRepository;
import com.d4rk.androidtutorials.java.data.repository.DefaultSupportRepository;
import com.d4rk.androidtutorials.java.data.repository.HomeRepository;
import com.d4rk.androidtutorials.java.data.repository.MainRepository;
import com.d4rk.androidtutorials.java.data.repository.QuizRepository;
import com.d4rk.androidtutorials.java.data.repository.SupportRepository;
import com.d4rk.androidtutorials.java.data.source.DefaultHomeLocalDataSource;
import com.d4rk.androidtutorials.java.data.source.DefaultHomeRemoteDataSource;
import com.d4rk.androidtutorials.java.data.source.DefaultQuizLocalDataSource;
import com.d4rk.androidtutorials.java.data.source.HomeLocalDataSource;
import com.d4rk.androidtutorials.java.data.source.HomeRemoteDataSource;
import com.d4rk.androidtutorials.java.data.source.QuizLocalDataSource;
import com.d4rk.androidtutorials.java.domain.about.GetCurrentYearUseCase;
import com.d4rk.androidtutorials.java.domain.about.GetVersionStringUseCase;
import com.d4rk.androidtutorials.java.domain.help.LaunchReviewFlowUseCase;
Expand All @@ -34,7 +30,6 @@
import com.d4rk.androidtutorials.java.domain.main.GetDefaultTabPreferenceUseCase;
import com.d4rk.androidtutorials.java.domain.main.MarkStartupScreenShownUseCase;
import com.d4rk.androidtutorials.java.domain.main.ShouldShowStartupScreenUseCase;
import com.d4rk.androidtutorials.java.domain.quiz.LoadQuizQuestionsUseCase;
import com.d4rk.androidtutorials.java.domain.settings.ApplyConsentUseCase;
import com.d4rk.androidtutorials.java.domain.settings.GetDarkModeUseCase;
import com.d4rk.androidtutorials.java.domain.settings.OnPreferenceChangedUseCase;
Expand Down Expand Up @@ -211,24 +206,6 @@ public SetConsentAcceptedUseCase provideSetConsentAcceptedUseCase(SettingsReposi
return new SetConsentAcceptedUseCase(repository);
}

@Provides
@Singleton
public QuizLocalDataSource provideQuizLocalDataSource(Application application, ExecutorService executorService) {
AssetManager manager = application.getAssets();
return new DefaultQuizLocalDataSource(manager, executorService);
}

@Provides
@Singleton
public QuizRepository provideQuizRepository(QuizLocalDataSource local) {
return new DefaultQuizRepository(local);
}

@Provides
public LoadQuizQuestionsUseCase provideLoadQuizQuestionsUseCase(QuizRepository repository) {
return new LoadQuizQuestionsUseCase(repository);
}

@Provides
@Singleton
public StartupRepository provideStartupRepository(Application application) {
Expand Down
25 changes: 0 additions & 25 deletions app/src/main/java/com/d4rk/androidtutorials/java/domain/quiz/LoadQuizQuestionsUseCase.java
View file
Open in desktop

This file was deleted.

42 changes: 0 additions & 42 deletions .../main/java/com/d4rk/androidtutorials/java/notifications/managers/QuizReminderManager.java
View file
Open in desktop

This file was deleted.

Loading
Loading